WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] [VT] add BT instruction support to VMX MMIO deco

To: "Xin Li" <xin.b.li@xxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] [VT] add BT instruction support to VMX MMIO decoder
From: "Jan Beulich" <JBeulich@xxxxxxxxxx>
Date: Mon, 24 Oct 2005 11:19:23 +0200
Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Mon, 24 Oct 2005 09:15:23 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <59D45D057E9702469E5775CBB56411F19C50AE@pdsmsx406>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <59D45D057E9702469E5775CBB56411F19C50AE@pdsmsx406>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
This seems a little questionable:

- in handle_mmio()'s INSTR_BT case value should be signed, not unsigned
(see definition of BitOffset in IA32 SDM Vol 2a Section 3.1)
- in the same place, you implicitly assume that va and gpa are
congruent over a range 2**29/2**61 bytes, which is likely wrong,
especially for mmio regions (while one could argue that there shouldn't
be accesses with a base address pointing into one mmio region, but the
effective address with the shifted bit offset included pointing into a
different on, I believe the hypervisor should actually verify this and
either handle it properly or fail the request)
- the alignment (and thus implicit range) limitations of real hardware
aren't followed (for e.g. a 32-bit operation, hardware confines the
access to the aligned 32-bit quantity addressed by EA+4*(BitOffset/32));
to match that you should either pass 1 instead of mmio_inst.op_size to
send_mmio_req, or you should calculate the offset from gpa depending on
the operand size (which is probably the better solution, although I
don't know which of the two possible mechanisms real hardware uses)

Jan

>>> "Li, Xin B" <xin.b.li@xxxxxxxxx> 15.10.05 08:14:03 >>>
add BT instruction support to VMX MMIO decoder.
Also extends TEST and OR instructions support for 16/32 bit
operations,
these are needed for windows.

Signed-off-by: Xin Li <xin.b.li@xxxxxxxxx>
Signed-off-by: Chengyuan Li <chengyuan.li@xxxxxxxxx>
Signed-off-by: Nakajima Jun <nakajima.jun@xxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>