This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [RFC] Cleaning up SCM debug

To: Anthony Liguori <aliguori@xxxxxxxxxx>
Subject: Re: [Xen-devel] [RFC] Cleaning up SCM debug
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Thu, 23 Jun 2005 10:44:00 +0100
Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, xense-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 23 Jun 2005 09:38:59 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <42BA2A6C.5000004@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <42BA2A6C.5000004@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

On 23 Jun 2005, at 04:20, Anthony Liguori wrote:

public/acm.h defines both an ACM_DEBUG flag and a printkd function that, if ACM_DEBUG is defined will convert to a printk. public/acm.h is included by userspace applications where printk isn't necessarily meaningful. Furthermore, it appears ACM_DEBUG is only used within Xen anyway so making it apart of the public headers doesn't make much sense.

Therefore, I'd like to move ACM_DEBUG and printkd into acm/acm_core.h. While at it, it seems like a good idea to change the printkd into either one of the existing Xen debug macros or to get rid of it altogether.

I wanted to check first to see if there was an emerging standard macro (a quick glance shows printk, DPRINTK, PRINT, and I'm sure there are at least a few more). Recommendations are appreciated.

If they are debug printk's then they should map onto DPRINTK. The PRINT macro is specific to debugging within the SEDF scheduler.

 -- Keir

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>