This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


RE: [Xen-devel] Latest bk (version 1.1730) breaks x86_64 dom0

To: "Petersson, Mats" <mats.petersson@xxxxxxx>
Subject: RE: [Xen-devel] Latest bk (version 1.1730) breaks x86_64 dom0
From: "Li, Xin B" <xin.b.li@xxxxxxxxx>
Date: Thu, 23 Jun 2005 17:20:41 +0800
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 23 Jun 2005 09:19:44 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcV3t37A+3lAhPK3QReHj4DDLbcHZQAE3/rQAAJtNdA=
Thread-topic: [Xen-devel] Latest bk (version 1.1730) breaks x86_64 dom0
Petersson, Mats wrote:
> Xin,
> I may be wrong, but when I read the comment:
>   * It is important that the masks are signed quantities.
> This ensures that 
>   * the compiler sign-extends a 32-bit mask to 64 bits if
>   that is required. */
> And I see the:
> #define PAGE_SIZE           (1UL << PAGE_SHIFT)

Yes, it should be:
#define PAGE_SIZE           (1L << PAGE_SHIFT)

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>