This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [patch] nx bit shouldn't get set when disabled

To: "Nakajima, Jun" <jun.nakajima@xxxxxxxxx>
Subject: Re: [Xen-devel] [patch] nx bit shouldn't get set when disabled
From: "Scott Parish" <srparish@xxxxxxxxxx>
Date: Wed, 8 Jun 2005 22:33:46 +0000
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, Scott Parish <srparish@xxxxxxxxxx>
Delivery-date: Wed, 08 Jun 2005 23:16:26 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <7F740D512C7C1046AB53446D37200173043350F1@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <7F740D512C7C1046AB53446D37200173043350F1@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/
On Wed, Jun 08, 2005 at 03:47:01PM -0700, Nakajima, Jun wrote:

> Agree on that part. Should read like:
>   pte = pte_offset_kernel(pmd, (vstart + (i*PAGE_SIZE)));
> + pte->pte &= __supported_pte_mask;
>   pfn = pte->pte >> PAGE_SHIFT;

I dissent. Same reason as yesterday: the above might work right now, but
as soon as we enable NX the NX bit will end up in the pfn/mfn.


Scott Parish
Signed-off-by: srparish@xxxxxxxxxx

Xen-devel mailing list