This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] tools top level makefile cleanup

To: Jerone Young <jyoung5@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] tools top level makefile cleanup
From: Christian Limpach <christian.limpach@xxxxxxxxx>
Date: Wed, 23 Mar 2005 21:11:07 +0000
Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxxx>, iap10@xxxxxxxxxxxx, kaf24@xxxxxxxxxxxx
Delivery-date: Wed, 23 Mar 2005 21:13:52 +0000
Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:references; b=EbHDgPZdNppVBP6a8K6e8bzJJN8qvTsgJUqZPTtgZx2wcIXAW7oQvUmd+YbEJ57novVX2WJb/bvm6mwb00S0AdLNY+RY2snyHvHUPXCo5EXM7EuzHkh1VaWXP5KeZVp+sNMKw+6VU+eAhaxO/jDuICHboStAc+J8v416ytUBCTY=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1111525821.3796.4.camel@thinkpad>
List-archive: <http://sourceforge.net/mailarchive/forum.php?forum=xen-devel>
List-help: <mailto:xen-devel-request@lists.sourceforge.net?subject=help>
List-id: List for Xen developers <xen-devel.lists.sourceforge.net>
List-post: <mailto:xen-devel@lists.sourceforge.net>
List-subscribe: <https://lists.sourceforge.net/lists/listinfo/xen-devel>, <mailto:xen-devel-request@lists.sourceforge.net?subject=subscribe>
List-unsubscribe: <https://lists.sourceforge.net/lists/listinfo/xen-devel>, <mailto:xen-devel-request@lists.sourceforge.net?subject=unsubscribe>
References: <1111525821.3796.4.camel@thinkpad>
Reply-to: Christian.Limpach@xxxxxxxxxxxx
Sender: xen-devel-admin@xxxxxxxxxxxxxxxxxxxxx
On Tue, 22 Mar 2005 15:10:21 -0600, Jerone Young <jyoung5@xxxxxxxxxx> wrote:
> I cleaned up the top level makefile in the tools directory. No major
> changes. Except I have it so that ioemmu is compiled only with x86_32.

I think the change below changes the behaviour:

> +SUBDIRS += check
> -install:
> -       $(MAKE) -C check
> -       $(MAKE) -C libxutil install
> +install:
> +       @for subdir in $(SUBDIRS); do \
> +               $(MAKE) -C $$subdir $@ || exit -1; \
> +       done

You're calling ``make -C check install'' while we want to call ``make
-C check''.  See the comments in tools/check/Makefile why we want
# Check this machine is OK for installing on.
# DO NOT use this check from 'make install' in the parent
# directory, as that target can be used to make an installable
# copy rather than actually installing.

At least you didn't try to go down the insane "try to make everything
build in parallel" road, it might work for the tools but you need to
be careful to make sure that targets which other targets depend on get
built first.  None of the fancy Makefile tricks which other people
have posted seem to take this into account :-(


This SF.net email is sponsored by Microsoft Mobile & Embedded DevCon 2005
Attend MEDC 2005 May 9-12 in Vegas. Learn more about the latest Windows
Embedded(r) & Windows Mobile(tm) platforms, applications & content.  Register
by 3/29 & save $300 http://ads.osdn.com/?ad_id=6883&alloc_id=15149&op=click
Xen-devel mailing list