WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] tools top level makefile cleanup

To: Jerone Young <jyoung5@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] tools top level makefile cleanup
From: Adam Heath <doogie@xxxxxxxxxxxxx>
Date: Tue, 22 Mar 2005 15:33:11 -0600 (CST)
Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxxx>
Delivery-date: Wed, 23 Mar 2005 12:39:02 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1111525821.3796.4.camel@thinkpad>
List-archive: <http://sourceforge.net/mailarchive/forum.php?forum=xen-devel>
List-help: <mailto:xen-devel-request@lists.sourceforge.net?subject=help>
List-id: List for Xen developers <xen-devel.lists.sourceforge.net>
List-post: <mailto:xen-devel@lists.sourceforge.net>
List-subscribe: <https://lists.sourceforge.net/lists/listinfo/xen-devel>, <mailto:xen-devel-request@lists.sourceforge.net?subject=subscribe>
List-unsubscribe: <https://lists.sourceforge.net/lists/listinfo/xen-devel>, <mailto:xen-devel-request@lists.sourceforge.net?subject=unsubscribe>
References: <1111525821.3796.4.camel@thinkpad>
Sender: xen-devel-admin@xxxxxxxxxxxxxxxxxxxxx
On Tue, 22 Mar 2005, Jerone Young wrote:

> I cleaned up the top level makefile in the tools directory. No major
> changes. Except I have it so that ioemmu is compiled only with x86_32.
>
> Signed-off-by: Jerone Young <jyoung5@xxxxxxxxxx>
>
> +all:
> +     @for subdir in $(SUBDIRS); do \
> +             $(MAKE) -C $$subdir $@ || exit -1; \
> +     done
> +
> +clean:
> +     @for subdir in $(SUBDIRS); do \
> +             $(MAKE) -C $$subdir $@ || exit -1; \
> +     done
> +
> +install:
> +     @for subdir in $(SUBDIRS); do \
> +             $(MAKE) -C $$subdir $@ || exit -1; \
> +     done

Don't do it like this.  make -j won't work.

Besides, don't use || exit.  Instead, use set -e.


-------------------------------------------------------
This SF.net email is sponsored by: 2005 Windows Mobile Application Contest
Submit applications for Windows Mobile(tm)-based Pocket PCs or Smartphones
for the chance to win $25,000 and application distribution. Enter today at
http://ads.osdn.com/?ad_id=6882&alloc_id=15148&op=click
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/xen-devel