This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] atomic_read

On 11 Mar 2005, at 16:52, Hollis Blanchard wrote:

Ahh... I assumed asm-x86/atomic.h was simply out of date, but I see now that you've modified it yourself. So _atomic_* should now be considered part of the arch->common interface? Further, it should actually *not* be an atomic access at all? Of course it will be faster ("better-quality") code if it's not assumed to be an atomic access... in which case isn't the naming a little misleading?

I noticed this problem because linux/include/asm-ppc64/atomic.h doesn't have _atomic_* functions. I guess this means I will need to implement my own non-atomic _atomic_* functions?

We only define single-word get/set macros (_atomic_read/_atomic_set). These are trivially atomic on any architecture we care about. In fact we only use them to set up local variables prior to pushing out to a shared atomic variable, so the atomicity doesn't really matter to us; it's a bonus.

 -- Keir

SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>