Re: [Xen-devel] [PATCH] atomic_read

[Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>]

On 11 Mar 2005, at 14:57, Hollis Blanchard wrote:

> Hi, I noticed that include/xen/sched.h uses _atomic_*() in a couple 
> places, while all other Xen code uses atomic_*(). In general I think 
> functions prefixed with an underscore are not part of the public 
> interface...
> This patch should be safe since atomic_*() just use volatile and 
> _atomic_*() do not.
> Side note: the Xen copy of atomic.h appears to be a little out of date 
> with respect to the Linux 2.6.11 version, in which _atomic_*() is no 
> longer present (only atomic_*() are).
The xen _atomic_* functions aren't like the old Linux ones -- they 
don't take a pointer to the atomic_t. We use this in the scheduler to 
produce better-quality code. The patch you sent won't compile because 
e.g., atomic_set and _atomic_set take different type parameters.
 -- Keir



-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/xen-devel