This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] atomic_read

On 11 Mar 2005, at 14:57, Hollis Blanchard wrote:

Hi, I noticed that include/xen/sched.h uses _atomic_*() in a couple places, while all other Xen code uses atomic_*(). In general I think functions prefixed with an underscore are not part of the public interface...

This patch should be safe since atomic_*() just use volatile and _atomic_*() do not.

Side note: the Xen copy of atomic.h appears to be a little out of date with respect to the Linux 2.6.11 version, in which _atomic_*() is no longer present (only atomic_*() are).

The xen _atomic_* functions aren't like the old Linux ones -- they don't take a pointer to the atomic_t. We use this in the scheduler to produce better-quality code. The patch you sent won't compile because e.g., atomic_set and _atomic_set take different type parameters.

 -- Keir

SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>