[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86/cpuidle: allocate processor_powers[] dynamically
- To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Jason Andryuk <jason.andryuk@xxxxxxx>
- Date: Fri, 6 Nov 2026 18:36:48 -0500
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=suse.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9UbMA8KwT+v/jWXBocaOx/JAX3SoO+6nvQu8Yzh23aM=; b=emP2tHuYiXKKytn+ytJexbUvRDpwXkKNYvI8YY/LoCh3ofTemb5XNxhiyTXd/m0I4uGFhdhXtMPgk7H3UmhdMMy5KOdUEnnQqw44iz4xrziq2ox+jWYf+ZaJcNBwx7pYECsn7unEcKWJYHo2+919Zp1L/Y6IzOm8xBNcnOiwUmVe1JE53qEXu6TxkjwqWHiD0kQC1TaPOI9nYk1yzSAg65Ybot4lFx++Tr4G7ln2/Ca/KNmzBOv7R2fowXMYtUB62X7Yd/mE2oNxHBYMvpwfPxzVnmbYauElAq79H7+vLpHsjCTA6Zwxof10a/10kypDbqPnHyFsW5uUvu3R6F5OMw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=KuEISEOXIL9FtfsppweZP7ZfJDJCc8NfktLIXUSzVw8KI2vYkoxplXBUxRj0CWGeJqsWCFDiFF3t6HhH4a/7817p5aG6P39nwOUSZfxRcMfeW0Wystl4CsMTRo9IoxDva8KrqXpnrd+X8c0c9i2gHiHMl8wQ/BVV8dt6l3JaWp7c+tQkYw9UlvgO/vvOPf1UJXmvP0oOLRUR94fApW0H6uul+CpeWERKfHaPkmvHrZTvE9rJFzUKBpcuAoTMy3dlTt4QLLMj/9z3L6QBxhe57L6OGo91oDeMTHhhIXP1lINM8qXno6e8Ai3ldGfwxD4AKoBQH6D/Berj4YJ8Xyn0yw==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=amd.com header.i="@amd.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Teddy Astie <teddy.astie@xxxxxxxxxx>, Roger Pau Monné <roger@xxxxxxxxxxxxxx>
- Delivery-date: Fri, 06 Nov 2026 23:37:03 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 2026-11-03 07:52, Jan Beulich wrote:
There's no need to have a NR_CPUS-dimensioned static array there.
Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
---
Some of the new conditionals checking processor_powers may arguably want
to check (really: might better have been put there long ago) xen_cpuidle
instead. Thoughts?
@@ -1694,6 +1702,15 @@ static int __init cf_check cpuidle_presm
if ( !xen_cpuidle )
return 0;
+ processor_powers = xvzalloc_array(struct acpi_processor_power *,
+ nr_cpu_ids);
+ if ( !processor_powers )
+ {
+ printk("CPUIDLE: disabled - not enough memory\n");
+ xen_cpuidle = 0;
+ return -ENOMEM;
+ }
+
mwait_idle_init(&cpu_nfb);
mwait-idle.c accesses processor_powers[], too, but that should not be
accessible since we don't make it into mwait_idle_init()?
If so:
Reviewed-by: Jason Andryuk <jason.andryuk@xxxxxxx>
Thanks,
Jason
|
