[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] tools/ocaml: Fix cleaning bindings test


  • To: <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Jason Andryuk <jason.andryuk@xxxxxxx>
  • Date: Fri, 6 Nov 2026 18:17:32 -0500
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oF1c2YLFZJ97GJ/QBH1SJYJ5NeZfcNSU6S44aYVqyKQ=; b=SGyTRf0ro9AbOarqv4ej48QFHEz+pJr2TPFfyGJshlicGRNoY275Wc2wewIG8cir6SCU/gZHLZxKzIfBKbc6M9ze2IWsQuu6EporWZfQBSlWy2ViuEHKzVn+bUH4TmW4/faTi7war3bPYMMWDp4eYkWYyBPlAYsaVrLR0zyRGGVqWM/Q5WB0bQegD/8xbN75FWYmUX0wTl8O4dy37dC7nfhQyiaF/HP5jHdNbSm3xngIuT+YYvb6aLEtJvIQY6HnPUuH4pCjplPQXrk11TS8FYcTwYRifxhhOnRbp1h7ouoQSn1z8hzE7844j4I6ARpN/6rAyg37uXZDMI1SsVL5/w==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Et3rO4KZJwvxF5XWydi3uqffKyEwM75z/ExXb4rKVSzdW1t1baqQJcEYQZmOZmN9S0iZyeXnahVSF/qXAU+XgB9V2MKt+LfFmFHj15AbHeISGR3DDitOsISs3lHJtv6wXTP0rgelxzKs2RrBgPHotEBEKD3lsGjrGhFqnXW4KDMnS+ba59HTEz34h+vTw2916lUtUfL7TFbGdv8GOdHDNLhLTwycv4Fq06ecRj3UmLv+rxSibwQugjWrJK7/tFuBDCEhCcsbtMdxFpyMU4WKGn9WkR70hv1JjG33byKyLQBNfZbsvmztLV8N4NhQik1OBlsK7eq3q2zYhbwHo4nz/Q==
  • Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=amd.com header.i="@amd.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
  • Cc: Jason Andryuk <jason.andryuk@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Andrii Sultanov <andriy.sultanov@xxxxxxxxxx>, Guillaume Thouvenin <guillaume.thouvenin@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>
  • Delivery-date: Fri, 06 Nov 2026 23:17:44 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

make clean fails in the bindings tests:

make[7]: Entering directory '/home/amd/xen/tools/ocaml/tests/bindings'
rm -f .*.d *.o *.so *.a *.cmo *.cmi *.cma *.cmx *.cmxa *.cmxs *.annot *.spot 
*.spit unix.cmxa -ccopt -L -ccopt ....
rm: invalid option -- 'c'
Try 'rm --help' for more information.

Split the compiler flags out of the LIBS variable, since LIBS is passed
to rm.  The individual *.cxma files are deleted in their respective
directories.

Fixes: d97847e858f1 ("tools/ocaml: Gitlab CI test for bindings")
Signed-off-by: Jason Andryuk <jason.andryuk@xxxxxxx>
---
 tools/ocaml/tests/bindings/Makefile | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tools/ocaml/tests/bindings/Makefile 
b/tools/ocaml/tests/bindings/Makefile
index 75f8babbaf..98fcb7aa5b 100644
--- a/tools/ocaml/tests/bindings/Makefile
+++ b/tools/ocaml/tests/bindings/Makefile
@@ -10,8 +10,8 @@ OCAMLINCLUDE += \
        -I $(OCAML_TOPLEVEL)/libs/xc \
        -I $(OCAML_TOPLEVEL)/libs/eventchn
 
-LIBS = \
-       unix.cmxa \
+LIBS = unix.cmxa
+LIBFLAGS = \
        -ccopt -L -ccopt $(OCAML_TOPLEVEL)/libs/mmap 
$(OCAML_TOPLEVEL)/libs/mmap/xenmmap.cmxa \
        -ccopt -L -ccopt $(OCAML_TOPLEVEL)/libs/eventchn 
$(OCAML_TOPLEVEL)/libs/eventchn/xeneventchn.cmxa \
        -ccopt -L -ccopt $(OCAML_TOPLEVEL)/libs/xc 
$(OCAML_TOPLEVEL)/libs/xc/xenctrl.cmxa \
@@ -21,7 +21,7 @@ LIBS = \
 PROGRAMS = test-ocaml-bindings
 OCAML_PROGRAM = test-ocaml-bindings
 
-test-ocaml-bindings_LIBS = $(LIBS)
+test-ocaml-bindings_LIBS = $(LIBS) $(LIBFLAGS)
 test-ocaml-bindings_MLSORTED = $(shell $(OCAMLDEP) -sort $(OBJS:=.ml))
 test-ocaml-bindings_OBJS = $(test-ocaml-bindings_MLSORTED:.ml=)
 
-- 
2.34.1




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.