[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v1 12/28] x86: apic: use APIC_EIO_ACK instead of open-coded 0
- To: xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: dmukhin@xxxxxxxx
- Date: Wed, 4 Nov 2026 17:33:29 -0800
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 205.220.161.53) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=ford.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=ford.com; dkim=pass (signature was verified) header.d=saarlouis.ford.com; dkim=pass (signature was verified) header.d=ford.com; arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fSWo+rzVhuBSLE4305o2x3UcvXK/wQrY+oQkdfxG9Zw=; b=h39SDFUKWG2OgGu/VtH0+urXvm0JKnTdbLMoV4BMLpn9SQpHywJtk9LLJtNYJfmKBNBFXrWZafBIatf4rK0yCzQjE2SfqCSEsEoVBwGPidpdqpQ1vPoTEnTrvtyXMrjxRuy4eywvdvgj/8hDtmJ0jyGG/Xq0Y4KGqtI6l3QYc0e5jSmTCyG6vLZVV+mKFJ5FaJNeqfaLDxQpPhEwy5nx2wCBhWj40KB/CJRDnwgXmnRhFj6fCJAbA+v3BFPhHUz1NsdeiUkNMaHtii5OfXCxMzxdEHZMRjpg6wKxydmXDnUvEOCO53qjubq2G3K39ZEvDrWfQYg5NbuG1gjpEIytVA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=urhZIDY1gT1c4qP2x0GhvhgYNgBWskkT78sfLHHvgalq58FpUJL/SuPnhESQY+AbrhXFPm8Udu2UTKokShVRfDbwENL384ZpqlqNMi8lAu9iK51GwfYkjRZzyQI6Ps8Lh/x2bd80j5G1YkUbYs136s8KEZ0IhhxefZWhD0w0qNpJxYLj9mIATH1t0bwo+0EHhAZQchotV0YfLVUSe92jlsl9fWZL/ClQ7XqxMFYqyBarbx+QaP+NpNBYxKCKmQWh19vptR8TjJSll53922PzqYh53Bi5+9N3MHm+snt6jQ7YJSCnx57NYOAtaEVR+JI+znTKTuyQsA1kzuOCrOAcEQ==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=ppford header.d=ford.com header.i="@ford.com" header.h="Cc:Content-Transfer-Encoding:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"; dkim=pass header.s=selector2-azureford-onmicrosoft-com header.d=azureford.onmicrosoft.com header.i="@azureford.onmicrosoft.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"; dkim=pass header.s=ppserprodsaar header.d=saarlouis.ford.com header.i="@saarlouis.ford.com" header.h="Cc:Content-Transfer-Encoding:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"; dkim=pass header.s=ppfserpocford header.d=ford.com header.i="@ford.com" header.h="Cc:Content-Transfer-Encoding:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"
- Cc: andrew.cooper3@xxxxxxxxxx, jason.andryuk@xxxxxxx, jbeulich@xxxxxxxx, roger@xxxxxxxxxxxxxx, teddy.astie@xxxxxxxxxx, dmukhin@xxxxxxx, Denis Mukhin <dmukhin@xxxxxxxx>
- Delivery-date: Thu, 05 Nov 2026 01:34:47 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Pser-m365-app: SER-APP
From: Denis Mukhin <dmukhin@xxxxxxxx>
Use the symbolic value in ack_APIC_irq() instead of open-coded 0.
Also, correct the EIO -> EOI typo in the constant name.
Signed-off-by: Denis Mukhin <dmukhin@xxxxxxxx>
---
xen/arch/x86/include/asm/apic.h | 3 +--
xen/arch/x86/include/asm/apicdef.h | 2 +-
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/xen/arch/x86/include/asm/apic.h b/xen/arch/x86/include/asm/apic.h
index f30d57ad22c5..a4f6d2c26ce1 100644
--- a/xen/arch/x86/include/asm/apic.h
+++ b/xen/arch/x86/include/asm/apic.h
@@ -155,8 +155,7 @@ void apic_wait_icr_idle(void);
static inline void ack_APIC_irq(void)
{
- /* Docs say use 0 for future compatibility */
- apic_write(APIC_EOI, 0);
+ apic_write(APIC_EOI, APIC_EOI_ACK);
}
extern int get_maxlvt(void);
diff --git a/xen/arch/x86/include/asm/apicdef.h
b/xen/arch/x86/include/asm/apicdef.h
index 112c1dc613a1..d3dc7b1d7643 100644
--- a/xen/arch/x86/include/asm/apicdef.h
+++ b/xen/arch/x86/include/asm/apicdef.h
@@ -25,7 +25,7 @@
#define APIC_ARBPRI_MASK 0xFF
#define APIC_PROCPRI 0xA0
#define APIC_EOI 0xB0
-#define APIC_EIO_ACK 0x0 /*
Write this to the EOI register */
+#define APIC_EOI_ACK 0x0 /* Docs
say use 0 for future compatibility */
#define APIC_RRR 0xC0
#define APIC_LDR 0xD0
#define APIC_LDR_MASK (0xFFu<<24)
--
2.55.0
|
