[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 18/39] xen/riscv: implement trap redirection to a guest
- To: Baptiste Le Duc <baptiste.le-duc@xxxxxxxxxx>
- From: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
- Date: Wed, 4 Nov 2026 12:41:32 +0100
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=20260707 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID"
- Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, Romain Caritey <Romain.Caritey@xxxxxxxxxxxxx>, Zheng Zhang <zhangzheng@xxxxxxxxxxx>, Alistair Francis <alistair.francis@xxxxxxx>, Connor Davis <connojdavis@xxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Roger Pau Monné <roger@xxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
- Delivery-date: Wed, 04 Nov 2026 11:41:46 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 10/20/26 5:25 PM, Baptiste Le Duc wrote:
On 10/20/26 5:22 PM, Baptiste Le Duc wrote:
[ ... 54 lines skipped ... ]
@@ -107,6 +107,11 @@
#define SIP_SSIP MIP_SSIP
#define SIP_STIP MIP_STIP
+/* stvec/vstvec: MODE is bits [1:0], BASE is bits [XLEN-1:2] */
+#define STVEC_MODE_MASK _UL(0x3)
+#define STVEC_MODE_DIRECT _UL(0x0)
+#define STVEC_MODE_VECTORED _UL(0x1)
Nit: STVEC_MODE_MASK needs a third tab for its value to line up with the
other two (and with the surrounding #define-s).
Instead of this small Nit, everything LGTM:
I suppose here you meant "Except of ...". I will apply your Nit.
Reviewed-by: Baptiste Le Duc <baptiste.le-duc@xxxxxxxxxx>
Thanks!
~ Oleksii
|
