Re: [PULL 00/25] Tracing patches

[Daniel P. Berrangé <berrange@xxxxxxxxxx>]

On Tue, Nov 03, 2026 at 10:59:43AM -0800, Richard Henderson wrote:
> On 11/2/26 10:58, Stefan Hajnoczi wrote:
> > The following changes since commit 56afd82bd4db9688f1c1c9d0e2ea163b8cde3283:
> > 
> >    Merge tag 'qemu-sparc-20261101' ofhttps://github.com/mcayland/qemu into 
> > staging (2026-11-01 08:37:48 -0800)
> > 
> > are available in the Git repository at:
> > 
> >    https://gitlab.com/stefanha/qemu.git tags/tracing-pull-request
> > 
> > for you to fetch changes up to 3b68720390b98f21e26ffcff8874851b7b49b7b7:
> > 
> >    trace: remove 'trace_event_get_state' wrapper (2026-11-02 13:52:14 -0500)
> > 
> > ----------------------------------------------------------------
> > Pull request
> > 
> > Daniel Berrangé's 'disable' property removal and associated cleanups.
> 
> Function signature change in here somewhere that didn't get propagated to
> rust?
> 
> https://gitlab.com/qemu-project/qemu/-/jobs/17710633655#L4275
> 
> > error[E0308]: mismatched types
> >    --> /builds/qemu-project/qemu/build/trace/trace-hw_char.rs:236:14
> >     |
> > 236 |       unsafe { (bindings::qemu_loglevel & bindings::LOG_TRACE) != 0 &&
> >     |  ______________^
> > 237 | |              
> > trace_event_state_is_enabled(_TRACE_PARALLEL_IOPORT_READ_DSTATE) } ||
> >     | 
> > |_____________________________________________________________________________^
> >  expected `()`, found `bool`
> >     |
> 
> etc.

Bug in the "trace: include qemu_loglevel_mask(LOG_TRACE) in guard" patch

Guess I must have not had --enable-rust set after I changed that code.

With regards,
Daniel
-- 
|: https://berrange.com       ~~        https://hachyderm.io/@berrange :|
|: https://libvirt.org          ~~          https://entangle-photo.org :|
|: https://pixelfed.art/berrange   ~~    https://fstop138.berrange.com :|