[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v8 05/18] hw/usb/hcd-ohci: Add an auto-hub property and leave it off
- To: "marcandre.lureau@xxxxxxxxxx" <marcandre.lureau@xxxxxxxxxx>
- From: Jamin Lin <jamin_lin@xxxxxxxxxxxxxx>
- Date: Tue, 3 Nov 2026 01:29:13 +0000
- Accept-language: zh-TW, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=aspeedtech.com; dmarc=pass action=none header.from=aspeedtech.com; dkim=pass header.d=aspeedtech.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GgG99Qy7/S+pgOVttA4wUNPSI3JdtSgVJ1Yo+vE0UPk=; b=Rh50sgGv/CJFJ6IRxcsb7BWVlwoFckXWlh8uMB+TLAzOhwCthtt8vsNpzBrzMuGoX4EOQFQQh0F6+ADd8Ya82PnyMnSU7diQIsh7x9hsAF2OqlhnjAxIZyPSIryZh7ypubYK0BXl7uSlo7UykFJZ7s0Im2YTuFAMRk4eaywbuJrAi6JaifHOGwCxX5oRbSQ6gdf1cix05ohAXZaQUjRHneepOUTteeJYDnh0hPfGsjIChgNOJ4P1kTy5LIoVJU1k/HV5kpYgxKpy0TcVusli32G8JVwuzGBLNhMGx0o0uQWd03Aq3GEpryne4miObJmT538FRBOaPpmx4T+DGKJ5MQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=NhGTv+5rNlEjyIDzWeRUsaCRzRwrCSAtDCBKNMTp75qALYdLi6ShGzSenkBXosP9sUdULB1uFAy/mRudQMSC1Bi62Kl2gIZEYTylvGSJ6ugZdLr5Pj/4dmxk8NfLrpUW3NgVdlv+wsP2yF9FE0RUcqt94gWYCxQgC+oqg3NkVWooY2RJhgM2Cm755h7LsXFfG4KDNUlfgYoxSAX/zx3ynJWFzxM+0Vtz5RZxVLhWlpN8FXzKQOw3+1JT+CufmyRsE7a7YOz9+2m5QQ5yE1iTMdknHlhyiqfOP8RrzqEvtWxhVuT+zs3IpxlbV+GI9gu3zgCu+j16SWvCJACYC90EHA==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=aspeedtech.com header.i="@aspeedtech.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:x-ms-exchange-senderadcheck"
- Authentication-results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=aspeedtech.com;
- Cc: "kraxel@xxxxxxxxxx" <kraxel@xxxxxxxxxx>, "junjie.cao@xxxxxxxxx" <junjie.cao@xxxxxxxxx>, "junjie.cao@xxxxxxxxx" <junjie.cao@xxxxxxxxx>, "clg@xxxxxxxx" <clg@xxxxxxxx>, Pierrick Bouvier <pierrick.bouvier@xxxxxxxxxxxxxxxx>, Peter Maydell <peter.maydell@xxxxxxxxxx>, Kane Chen <kane_chen@xxxxxxxxxxxxxx>, Philippe Mathieu-Daudé <philmd@xxxxxxxxxxxxxxxx>, Tyrone Ting <kfting@xxxxxxxxxxx>, Hao Wu <wuhaotsh@xxxxxxxxxx>, Zhao Liu <zhao1.liu@xxxxxxxxx>, Richard Henderson <richard.henderson@xxxxxxxxxx>, Helge Deller <deller@xxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Anthony PERARD <anthony@xxxxxxxxxxxxxx>, "Edgar E. Iglesias" <edgar.iglesias@xxxxxxxxx>, "open list:All patches CC here" <qemu-devel@xxxxxxxxxx>, "open list:ASPEED BMCs" <qemu-arm@xxxxxxxxxx>, "open list:X86 Xen CPUs" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Troy Lee <troy_lee@xxxxxxxxxxxxxx>
- Delivery-date: Tue, 03 Nov 2026 01:29:28 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHdaquj7EwX/4j+EkiS0LfitZAyFLca0acAgAC+S3A=
- Thread-topic: [PATCH v8 05/18] hw/usb/hcd-ohci: Add an auto-hub property and leave it off
Hi Marc-André,
> Subject: Re: [PATCH v8 05/18] hw/usb/hcd-ohci: Add an auto-hub property and
> leave it off
>
> > Add auto-hub and leave it off. hw_compat_11_1 turns it on for pci-ohci
> > and sysbus-ohci, so an older machine type keeps the hub it has today
> > and a guest saved by an older QEMU still loads.
> >
> > pc87560-ohci is its own PCI front end, not a pci-ohci, so it defines
> > the property itself.
> >
> > A companion OHCI adds its ports to the EHCI bus instead of making one,
> > so there the EHCI property decides.
> >
> > Suggested-by: Gerd Hoffmann <kraxel@xxxxxxxxxx>
> > Signed-off-by: Jamin Lin <jamin_lin@xxxxxxxxxxxxxx>
> > Message-ID: <20261102092201.1729245-6-jamin_lin@xxxxxxxxxxxxxx>
> > ---
> > hw/usb/hcd-ohci.h | 1 +
> > hw/core/machine.c | 2 ++
> > hw/usb/hcd-ohci-pci.c | 1 +
> > hw/usb/hcd-ohci-sysbus.c | 1 +
> > hw/usb/hcd-ohci.c | 1 +
> > hw/usb/pc87560-ohci.c | 1 +
> > 6 files changed, 7 insertions(+)
> >
> > diff --git a/hw/core/machine.c b/hw/core/machine.c index
> > f79337e7d774..22d2b834595a 100644
> > --- a/hw/core/machine.c
> > +++ b/hw/core/machine.c
> > @@ -47,6 +47,8 @@ GlobalProperty hw_compat_11_1[] = {
> > { "pci-ehci-usb", "auto-hub", "on" },
> > { "base-xhci", "auto-hub", "on" },
> > { "pci-uhci-usb", "auto-hub", "on" },
> > + { "sysbus-ohci", "auto-hub", "on" },
> > + { "pci-ohci", "auto-hub", "on" },
>
> So it also needs pc87560-ohci, no?
>
We can add pc87560-ohci to the table, but it will not set anything.
hw_compat_11_1 only applies to a machine type that asks for it, and
hppa has no versioned machine type. C3700 is just "C3700". I added the
entry and built it: auto-hub still reads false on C3700, so the entry
never fires.
Thanks,
Jamin
> --
> Marc-André Lureau <marcandre.lureau@xxxxxxxxxx>
|
