[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v7 38/65] qom: convert scalar properties to QAPI-aware registration



Marc-André Lureau <marcandre.lureau@xxxxxxxxxx> writes:

> Hi
>
> On Fri, Oct 30, 2026 at 12:48 PM Markus Armbruster <armbru@xxxxxxxxxx> wrote:
>>
>> Marc-André Lureau <marcandre.lureau@xxxxxxxxxx> writes:
>>
>> > Reviewed-by: Amit Machhiwal <amachhiw@xxxxxxxxxxxxx>
>> > Signed-off-by: Markus Armbruster <armbru@xxxxxxxxxx>
>> > Signed-off-by: Marc-André Lureau <marcandre.lureau@xxxxxxxxxx>
>>
>> How did you create this patch?  It looks almost mechanical.
>
> Repeated grep / multi-cursor in zed iirc
>
>>
>> It misses a few conversions, almost certainly in code added since you
>> made this patch.  I can take care of them.
>
> Not surprising after several months.

Not at all.  Almost surprised it's so few.

[...]

> Are you working on v8 or should I start rebasing?

I think it's overall less work if I do v8 at this point.




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.