[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH net-next 03/15] net: skbuff: fail checksum validation when the skb can't be checksummed
- To: netdev-bot+sashiko@xxxxxxxxxx
- From: Mina Almasry <almasrymina@xxxxxxxxxx>
- Date: Fri, 23 Oct 2026 07:12:39 -0700
- Arc-authentication-results: i=1; mx.google.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=xkLt3lfrbsQ7vfYdIskLImlrhPYw2t6MqVNHm8RXqsw=; fh=OJliEttHmb/xASVAeF1CSy2INZws7GMjffaELyUwywo=; b=BNV/3hiimZE6fEFek1J+POlMFxs7332nj6c5Z541kv4BjpVB82rNgeUsYO9BFV/ZGa zjrzbl1hklXOgZCVSAyu/JT8IscrV3MLfUxB/zUBega7m5CjAncVi5uhsTXOYoZYK4IL Z05vGunNk7APiRbUN5NnEKluUWzSzr9ryykBTG6oDXVVJD7oYhNLSsmLbxDmlGPhDQnp GeD6jN4ZVDj1Wgsu2rc1iRlnSRrrQvCKh5HxCFqy2jeF4JaVMw6NCWMAy9+JWfVoTpK/ 1ANp6PT0zl2+5DmI67cQsv5wQ6/CBIOWb4hvKJnoD/li1bYIKh33+chEdXtHJOQMVtXK i27w==; darn=lists.xenproject.org
- Arc-seal: i=1; a=rsa-sha256; t=1792764779; cv=none; d=google.com; s=arc-20260327; b=OtTy3+CEaJ9Y4J75PJF4mSgcwJ8TlevxYckuZgfa7aZ8fpcqJUIh+EOBLprrshx1Wi Um9Jk+7SKrjwbs/J5svcAQeLUwnPpN0NyaqUH2tpJXqkINKbvSVaEyUVxFxWqEG+FiXp eTQQco3vcM1C8mP6afMLpFiT2krgQjHOKw8MLLjZPDwXvjYzCGgthF7JXtv04Su9M8uy 8u9MF8gonK7pTDvsvAVb2qa6u/ssN4fpPU4Ld4bLacM0MHlPO9/tnm2nOfmJPB7uF1v8 uCMk06X03nUBXUbm5jeoEyWLtXMl4fs6uBZYT9A2B+Ps/TuQ3+QXOrM/dcN01rK0lZ14 KaJg==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Content-Transfer-Encoding:Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To:References:MIME-Version"
- Cc: josef@xxxxxxxxxxxxxx, davem@xxxxxxxxxxxxx, edumazet@xxxxxxxxxx, kuba@xxxxxxxxxx, pabeni@xxxxxxxxxx, horms@xxxxxxxxxx, andrew+netdev@xxxxxxx, jgross@xxxxxxxx, sstabellini@xxxxxxxxxx, willemdebruijn.kernel@xxxxxxxxx, fmancera@xxxxxxx, david.laight.linux@xxxxxxxxx, netdev@xxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Fri, 23 Oct 2026 14:13:09 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Thu, Oct 22, 2026 at 9:52 PM <netdev-bot+sashiko@xxxxxxxxxx> wrote:
>
> Thank you for your contribution! Sashiko AI review found 4 potential
> issue(s) to consider.
>
> Critical: 0 · High: 2 · Medium: 1 · Low: 1
>
> If you believe none of the issues are legitimate, please reply to each
> issue of Medium severity or higher and explain why the AI is wrong.
> If any of them are legitimate and you plan to respin, please let patchwork
> know by including "pw-bot: cr" as a separate line at the end of your reply
> (one such reply per series is enough).
>
> - [High] The fix does not hold when conntrack checks checksums first.
> - [High] __skb_gro_checksum_complete() (net/core/gro.c:794-813) has the
> same false-accept defect this commit fixes in…
Both high's here seem like legitimate issue, al though the latter is
maybe pre-existing.
--
Thanks,
Mina
|
