[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] xen/x86/hvm: Propagate emulated CR2 writes to the VMCB
- To: <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Stefano Stabellini <stefano.stabellini@xxxxxxx>
- Date: Tue, 20 Oct 2026 14:33:15 -0700
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4mLmovPYFSQH+pk2lrvaukpqTjj7fDJAJGejPwRKTs4=; b=hv+4ZMP8KjSyfCbww+7tZMiUuKEA+6jEK+TUPXmBVccmv6MzvJvVVouVtafOal6y0hHb3Gko89DElBZ7Hg04Tnq826ohkxADPixq0iN2dC1h0LymXw/sOWa31nGt3fhKZK3ygGeeCb+QLbcFw6sOXEisiG2cOj/+HTTyNq3UAj6JYXK6SqH50MK7DB4QmC6cYLSea7//uiVHgTqejy009W1/g4OGSVW8vNWijgi9ybaDeGZonRb07YA0Yz4rw1SDU+JanskXEl/+nHzvvXUIrhBfmfNuMH/LLKF9GyDxprSFAII+3tRudLBLFoNp3AP3hczSucj/mXeVN5nIACh2iA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=X3QCgAMpPQUIqx3CKVoR/1xEbntiUU+97w7Fi19SVtw3IdcmS22p1W+UTdltIkYv2Pc/2OUpq/GDrQYDMRgRztvJqQNlckTQoLmdeDxz6V1+L2bpwoMMhvp7l/zVVX35fhkKvL12WW2ysQ46hP6GvB0jqJBKqlMriCe4iM/xE6ozdmNQ2E0//EH6fmmuMkTrm5+PSpsPDxL+VxZyqsG+Ub47k2xgwyLD1/UaeesPLrVcRpL2rhQNLCYqnrYGEHRTy4i3OYC6zuSj9BrYORzdCLeLMSeD9/YnH1OFA0NBk355AonlTb04qIN0JkD4z9AUM42Q1hDgkF86a7LToMDqYQ==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=amd.com header.i="@amd.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
- Cc: <jbeulich@xxxxxxxx>, <andrew.cooper3@xxxxxxxxxx>, <roger@xxxxxxxxxxxxxx>, <jason.andryuk@xxxxxxx>, <teddy.astie@xxxxxxxxxx>, <stefano.stabellini@xxxxxxx>
- Delivery-date: Tue, 20 Oct 2026 21:33:47 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
hvmemul_write_cr() updates guest_cr[2] but, unlike every other writer of
it, doesn't call hvm_update_guest_cr(). On SVM, CR2 is loaded from
the VMCB, so the emulated write never reaches the guest, and the next
VMExit overwrites guest_cr[2] with the stale VMCB value.
Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxx>
---
xen/arch/x86/hvm/emulate.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/xen/arch/x86/hvm/emulate.c b/xen/arch/x86/hvm/emulate.c
index c09ea002ec..cd2831d34b 100644
--- a/xen/arch/x86/hvm/emulate.c
+++ b/xen/arch/x86/hvm/emulate.c
@@ -2350,6 +2350,7 @@ static int cf_check hvmemul_write_cr(
case 2:
curr->arch.hvm.guest_cr[2] = val;
+ hvm_update_guest_cr(curr, 2);
rc = X86EMUL_OKAY;
break;
--
2.43.0
|
