[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 2/5] vpci: use a local variable for the BAR rangeset
- To: Mykyta Poturai <Mykyta_Poturai@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Jason Andryuk <jason.andryuk@xxxxxxx>
- Date: Mon, 19 Oct 2026 15:09:33 -0400
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=epam.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CCAkuRImuKtUiIUpukaEwCtuKwnf8f/9h60I7T0owRM=; b=kFS2QE5lzzP1rvPqZNhtf8FCGzcJPC4EUGnEi/WzTBbobG+vP3mfY/WU5Vwe/0sUc79gTxeKWCItDddfgDGmImYl6LnyKJFVx5Nddj2mrsCqBSkDxlQvCwYieFYRC/xbuP77q8d+FbhPosrVvLgWq7Cp/LC89LSv6vI5J/URLVSO2BisXijusZauFFR2QyNUrr+oY3//4onzWEG24W4AIMGFIJHPDLG40QyGXuhGzAlfiu7Z5L+9Cf+ZxqUJobrZ+CKU/9ZkQG3P4Y0HsVKfIk5Qoiu8vamc+9Ziy+ovwOdtgsprqyyxBPT05XB0dZDBCovhTmUjRsodD001qMPWAw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=U5bk+YZ/AOmTuhLDUUqQ4XUsIJwor90tueWqQ+rA5Rws92K3y4NfhixH9wMUFu3peQS/DTrIl/OpYqACzrD/GAJb33kkD6JQ2isya4Bt5zIwwWK5RFgEySI7sE4Xn7pH1qqZCSYQeYUuyin34IHBI8cBEYgqLJaZPpOklh6SKEWezuVEJDuXHm2yKBgLs0MsEpIE11WGB/UXSHO+M8QF7XtGEQfFxgVLzkgvp4g/L7n+eP1tmmz88VaDBwAOTRDOepF7fImpssMb5zMj8H40y7swoUzbPYlEzmMaHaIXB9WMspjqWVW4hKwiaL6P+0jM9GrtA49Fgqr/4bh7FHplcA==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=amd.com header.i="@amd.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
- Cc: Roger Pau Monné <roger@xxxxxxxxxxxxxx>, "Stewart Hildebrand" <stewart.hildebrand@xxxxxxx>
- Delivery-date: Mon, 19 Oct 2026 19:17:40 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 2026-10-15 10:08, Mykyta Poturai wrote:
From: Mykyta Poturai <Mykyta_Poturai@xxxxxxxx>
In the BAR (un)mapping paths latch the rangeset of the BAR being
processed into a local variable, instead of dereferencing struct
vpci_bar on every use. Preparatory work for moving the rangesets out
of struct vpci_bar.
No functional change.
Signed-off-by: Mykyta Poturai <mykyta_poturai@xxxxxxxx>
Signed-off-by: Stewart Hildebrand <stewart.hildebrand@xxxxxxx>
I guess you need a second S-o-B after Stewart's since you are
submitting? Unless...
---
v3->v4:
* new patch, split out of "vpci: Use pervcpu ranges for BAR mapping" so
that the non-functional churn is separate from the functional change
... it is something totally created by you. Then you can drop Stewart -
I think.
@@ -218,8 +219,7 @@ bool vpci_process_pending(struct vcpu *v)
{
spin_lock(&pdev->vpci->lock);
/* Disable memory decoding unconditionally on failure. */
- modify_decoding(pdev, v->vpci.cmd & ~PCI_COMMAND_MEMORY,
- false);
+ modify_decoding(pdev, v->vpci.cmd & ~PCI_COMMAND_MEMORY, false);
This seems like an unrelated change. I think you should drop it and
incorporate into the next patch touching this line.
With that:
Reviewed-by: Jason Andryuk <jason.andryuk@xxxxxxx>
|
