[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH net-next 15/15] net: update comments that still describe the skb BUG_ON()s
- To: Josef Bacik <josef@xxxxxxxxxxxxxx>
- From: Mina Almasry <almasrymina@xxxxxxxxxx>
- Date: Mon, 19 Oct 2026 08:09:44 -0700
- Arc-authentication-results: i=1; mx.google.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=AWZK7vcabRIRlNI5I0Qlo1HJVZRHgTLgm0d3t+p60UQ=; fh=j7KtDfAVZ0xCKnedpo/AfKr/BVAFGsqOgyOvKdv95/8=; b=EWXZ7qU4X+V5+wxB1ApFMNEEFupM5ZGo7z02ZU+JjhhMd7mkv/l181vKiDE5//1MdR pxKKnDlLwlr1qfvvqc1q6eWyeuEDWijSgqTOQY6EGRiU6F0tkSI9enrDABiPBL6vTWkR 3SzA8ZHAueN9CJQcIfxePFTM4owNHOmvvZRYNdVVc+5WNBbGZm6zeEaksZP21B3g+XUl 9A6eaLtFDWN9+te3Ay1hQeg/FzG6gJvBrlZZbbFaDbUqtell3phz5zskOGUj2Wtdcu/9 hna0UiA4fjE7Ofkp7/cFdEzZ0bpgXUH3jVNiHLT/wvqOfZRcZhQ2Dol32W8gt+chmSTa PN8Q==; darn=lists.xenproject.org
- Arc-seal: i=1; a=rsa-sha256; t=1792422597; cv=none; d=google.com; s=arc-20260327; b=kZuQUrZ2AwFms4xAcIdBntRPYfpHZHvjOVh5khkOalI/eO9EfJalWOd6b5O4o3S3sB hgeiDsGoPKmDVUEsdWZvzOW+xUDiWOFnjzaQsOMxNJkxrHfs2gQo7fZZgaL9YlOMN+9F +RLducZfalPqlF5Y6Rh9tpuF9tVBSfH/L6L9HOKm8Y4jAi/yp39Hg1CL4uTri0+OdsUj Rr7hxcU/P0rTUVR+0CdBwtP319xcfsWJlw33hg3OSmOHGMsGDi4xeEm5gf6sT15kE1Wu 1ALg7Qr+f+rS/vXt1P5+aZ3kwhYv8Ypsu0ZJ2QcyXj1yOvFSq91Ju5eFaXlZN6xfVbxZ jSfg==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Content-Transfer-Encoding:Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To:References:MIME-Version"
- Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>, Eric Dumazet <edumazet@xxxxxxxxxx>, Jakub Kicinski <kuba@xxxxxxxxxx>, Paolo Abeni <pabeni@xxxxxxxxxx>, Simon Horman <horms@xxxxxxxxxx>, Andrew Lunn <andrew+netdev@xxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Willem de Bruijn <willemdebruijn.kernel@xxxxxxxxx>, Fernando Fernandez Mancera <fmancera@xxxxxxx>, David Laight <david.laight.linux@xxxxxxxxx>, netdev@xxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 19 Oct 2026 16:05:42 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Mon, Oct 19, 2026 at 6:51 AM Josef Bacik <josef@xxxxxxxxxxxxxx> wrote:
>
> The skbuff BUG_ON() conversions left a few comments behind:
>
> - bpf_skb_net_grow() says skb_segment() BUG()s on a frag_list with
> head_frag set at the downgraded MSS. It fails the segmentation and
> the packet is dropped, which is still why the skb gets linearized.
> - The GSO KUnit test says the non-uniform frag_list case would hit
> BUG_ON(i >= nfrags) with SG. That check now fails with -EINVAL.
> - The skb_to_sgvec() kernel-doc doesn't list the -EINVAL that
> __skb_to_sgvec() returns when @offset and @len run past the end of
> the skb.
>
> No functional change.
>
> Assisted-by: LLM
> Signed-off-by: Josef Bacik <josef@xxxxxxxxxxxxxx>
I would have preferred this change is squashed with the code change;
if you re-spin for another reason maybe do that.
Acked-by: Mina Almasry <almasrymina@xxxxxxxxxx>
|
