[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH v3 28/28] i8259_common.c: add missing 0x prefixes to "info pic" output


  • To: pbonzini@xxxxxxxxxx, richard.henderson@xxxxxxxxxx, mst@xxxxxxxxxx, sstabellini@xxxxxxxxxx, anthony@xxxxxxxxxxxxxx, edgar.iglesias@xxxxxxxxx, qemu-devel@xxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • From: Mark Cave-Ayland <mark.caveayland@xxxxxxxxxxx>
  • Date: Mon, 19 Oct 2026 13:05:00 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SZiLewJ31Wd7JJfgU0jxATyKUq9AnyFgswSLPaZDyF0=; b=yZSx9MaMomJeipZvKrHJFLt9y62Gw3HnNTiSVbW6K0qXxW4mdZ1gVKCUFdgqc99IJyVbg2pqgI1Jpn3cmiiHI1nhQ+69zzxm6G0WholvLcP7qZkR7edponaHA5xCtL2XcTeBjDd+Lcck1V1ydiT9e2Sj1at/ecLTp9w6yPVMwwnKWleaFdxe/ZZry3JOAzt1h7QeMaP0lz1P73Mc2SjMbfIWm/zgSwSGXEj0kHrZsLihSel11Q3C8fq9rKRZxZgIv4XzOyXNIWAua32dsg1IX0Zm9XrhwvKAM8K3y3b74tNUjn83p4umlqT6Bob5irbedavlwWgvxjBmgwF75EqOIQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=VRZQ8C6fAfyy96MoxUzpVha+2XHULH0uU93VZD9XPIOwmPE4UYdFtjDdf12FIS5g7FApd763OcEdQ/OMTLesAtB5EqJivH5R6k/MtzJQUNgJhE0dZUz2602Rz1XYAGTsxCTtPBgKEEjs0YBMFQs+He1qLvKdWh8ADqumm2ws68kmm82KS750r8XL67xuPDxjPDC/3fktGFvFBpLC7OqsYBrLgMSwDO/p5asi7mS5AYtO7mp7yq5+rcICC8Jz1lYdncS5rovcDWbq5a053GtfDTqs+x+pZnPSr6SlHAt5JtE+GfnaOcUTB436CkbtFxpuyKFYZQJsQZb9sx2w8DREbw==
  • Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=proofpoint20171006 header.d=nutanix.com header.i="@nutanix.com" header.h="Content-Transfer-Encoding:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"; dkim=pass header.s=selector1 header.d=nutanix.com header.i="@nutanix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
  • Authentication-results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nutanix.com;
  • Delivery-date: Mon, 19 Oct 2026 12:07:01 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

This indicates that the specified register values are being output in hex.

Signed-off-by: Mark Cave-Ayland <mark.caveayland@xxxxxxxxxxx>
Reviewed-by: Peter Maydell <peter.maydell@xxxxxxxxxx>
---
 hw/intc/i8259_common.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/hw/intc/i8259_common.c b/hw/intc/i8259_common.c
index 3bafd81ea7..ee325a659a 100644
--- a/hw/intc/i8259_common.c
+++ b/hw/intc/i8259_common.c
@@ -119,8 +119,9 @@ static void i8259_common_print_info(InterruptStatsProvider 
*obj, GString *buf)
     I8259CommonState *cs = I8259_COMMON(obj);
 
     i8259_common_dispatch_pre_save(cs);
-    g_string_append_printf(buf, "pic%d: irr=%02x imr=%02x isr=%02x hprio=%d "
-                           "irq_base=%02x rr_sel=%d elcr=%02x fnm=%d\n",
+    g_string_append_printf(buf,
+                           "pic%d: irr=0x%02x imr=0x%02x isr=0x%02x hprio=%d "
+                           "irq_base=0x%02x rr_sel=%d elcr=0x%02x fnm=%d\n",
                            cs->master ? 0 : 1, cs->irr, cs->imr, cs->isr,
                            cs->priority_add,
                            cs->irq_base, cs->read_reg_select, cs->elcr,
-- 
2.43.0




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.