[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/3] tools/libxenstat: don't crash when /sys/class/net can't be opened



On 2026-10-16 13:55 +0200, Baptiste Le Duc wrote:
> We might want a message telling it failed as it's already done in the
> file for SYSFS_VBD_PATH.
> 
> I'd propose:
> if (d == NULL) {
>     perror("Error opening /sys/class/net");
>     return;
> }
Please disregard my previous reply, it was a draft sent by
mistake...

Returning silently seems to be fine as missing /sys/class/net isn't fatal here.
Sorry for the noise.

So:
Reviewed-by: Baptiste Le Duc <baptiste.le-duc@xxxxxxxxxx>

-- 
Baptiste Le Duc <baptiste.le-duc@xxxxxxxxxx>



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.