|
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [PATCH] tools/libxenstat: don't lose all VIFs when dom0 has no Linux bridge
On Mon, Oct 05, 2026 at 04:49:43PM -0400, Jason Andryuk wrote:
> On 2026-10-03 03:17, Olivier Lambert wrote:
> > xenstat_collect_networks() looks for a Linux bridge (a
> > /sys/class/net/*/bridge directory) so that, with bonding, dom0 can be
> > given the bridge's counters. When there is none, as on hosts using Open
> > vSwitch (the XCP-ng default), routed networking or only libvirt's
> > virbr0 (which is excluded on purpose), getBridge() leaves devBridge
> > empty. strstr(iface, "") then matches every interface, and devNoBridge
> > is just "p", so every VIF with a standard name (vifN.M, vifN.M-emu)
> > takes the bridge branch instead of being attached to its domain. Every
> > domain ends up with zero networks, and xentop shows NETS 0.
> >
> > Only take the bridge branch when a bridge was actually found.
> >
> > Fixes: 1fd93d4f8cb8 ("xenstat: Linux dom0 statistics for case we use
> > network bonding")
> > Assisted-by: Claude-Code:claude-opus-5-5
> > Signed-off-by: Olivier Lambert <olivier.lambert@xxxxxxxxxx>
>
> Tested-by: Jason Andryuk <jason.andryuk@xxxxxxx>
> Reviewed-by: Jason Andryuk <jason.andryuk@xxxxxxx>
Acked-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
Thanks,
--
Anthony Perard | Vates XCP-ng Developer
XCP-ng & Xen Orchestra - Vates solutions
web: https://vates.tech
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |