[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v1 5/6] nestedsvm: Fix deferred event injection


  • To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • From: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>
  • Date: Fri, 11 Sep 2026 14:37:57 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/yIPE0AGlvw7y8vt5wZos56FplFsOc+Cx0ylaz1jFSM=; b=ROQlaFwC97084EOR4Zfh7OW9JN8wq/FLOFb1Fl4j8WK9VNq5NHV+JUNQjZrlUOvrtlxpLY40brrj+Kv8mx5bbwypxcn/iIutN0fWxgoW5FelWh4TSnZf0KfUv8DANjvecoPa8x6uvvDoH1CCFrDonHgauzMtZrNAnHkTp7Lm5Y9Ym7P7Thwyoluk91h4mrLPPgXwyMh4i0AQ8aFLi/mUC22rSvLizlVeUycxxAypg6SGH2e3/Vv/IT1JETxNJ31G70BXPfDpVrDgdIcTIHpYtgwXwD34jMBGN3mf1ihTMf3YUaMOaGIe85b0OnAOOxqct7VAxCCZshuYN9aSLpi1Yg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=TMF+sCH8Gs8HDZNMV0V8/0j+tjd9pxraqhKNi1vBOT1WyDsOp+ktl1xmLtjOlz19HwPDYbfR6xJJ+QY0MKdXYTrVL84URjTNkkrw90VKA1fZc0m8HMZu52T0eOG27jkIdPI8rtSWBikVJhTECWHbBfWqx79nADT+z8ssrdMMdwyL2EI5UBG1RLQnL4J2IjLhd1ZergZG05qk4xqrI+sMaGWrIiEcTBL7bbMITNBsG7TqQP+B1EbqTmRybHCUiLFKHxTHm3th2sDKlnMLDvcAw+aOmI0viOtz2wa7XANpibLIl3xl/aQBMd7/gqqiVk+oXy2CXn1CKq4DlPKk5Tt/Vg==
  • Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
  • Cc: Jan Beulich <jbeulich@xxxxxxxx>, Jason Andryuk <jason.andryuk@xxxxxxx>, Teddy Astie <teddy.astie@xxxxxxxxxx>, Roger Pau Monné <roger@xxxxxxxxxxxxxx>
  • Delivery-date: Fri, 11 Sep 2026 13:38:08 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 9/11/26 11:56 AM, Andrew Cooper wrote:
On 26/05/2026 1:40 pm, Ross Lagerwall wrote:
If an event for L1 occurs while L2 is running, Xen should inject
VMEXIT_INTR and the event into L1.

nestedsvm_vcpu_interrupt() and nestedsvm_vmexit_defer() set this up to
be handled later by nsvm_vcpu_vmexit_inject() after the switch back to
L1. However, the code there appears to be bogus and completely ignores
the source/vector set up in the first place. Fix this by using the
values to properly inject the event.

Fixes: 9a779e4fc161 ("Implement SVM specific part for Nested Virtualization")
Signed-off-by: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>

I'm reasonably sure this will be unnecessary when we fix the underlying
problem of deferred entry/exit.


Are you suggesting if the VMEXIT is done inline in nestedsvm_vcpu_interrupt(),
then it can just fall through to the normal L1 interrupt injection code (in
svm_intr_assist())?

Ross



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.