[PATCH v5 0/6] Fix ARM domcreate

[Julian Vetter <julian.vetter@xxxxxxxxxx>]

Hello Michal and Andrew,
Thank you Michal for the very thorough review on v4! I have addressed
The GICv2-compat-mode handling in arch_sanitise_domain_config(), the
gic_domctl_hw_version() naming, the XEN_DOMCTL_INTERFACE_VERSION bump,
and signalling to libxl whether the timer frequency came from the host
DT.
In regards to your other comment Michal "what guarantees mask is a
single bit?", and the answer is "nothing". You're right there is nothing
that prevents anyone trying to check multiple bits or passing a bitmask,
e.g., "XXX|YYY". This is why I went back to the original implementation.
In know your previous comment Andrew and I fully agree, and it will
probably get worse in the future to have tons of small 3 line inline
functions like this to check all sorts of features. But after trying for
a bit, I believe fixing this in a proper way, is more complicated than I
initially thought and merits its own patch series. Because adding this
to this series would bloat it with more somehow "unrelated" changes.
I'd rather leave a proper arch_capabilities_arm_has() as a separate
cleanup for later. Sorry for the back-and-forth on this one and I hope
you both agree.

Signed-off-by: Julian Vetter <julian.vetter@xxxxxxxxxx>
---
Andrew Cooper (1):
  ARM/sysctl: Expose the supported guest GIC modes in physinfo

Julian Vetter (5):
  xen/arm: report proper GIC version via XEN_DOMCTL_getdomaininfo
  tools/arm: choose GIC version explicitly instead of relying on
    GIC_NATIVE
  xen/arm: remove XEN_DOMCTL_CONFIG_GIC_NATIVE from the ABI
  xen/arm: report clock_frequency via sysctl physinfo, not createdomain
  xen: make config argument const

 CHANGELOG.md                                  |  4 ++
 docs/man/xl.cfg.5.pod.in                      |  9 +--
 .../include/xen-tools/arm-arch-capabilities.h | 31 +++++++++
 tools/libs/light/libxl.c                      |  1 +
 tools/libs/light/libxl_arm.c                  | 66 +++++++++++++++++--
 tools/libs/light/libxl_types.idl              |  5 +-
 tools/ocaml/libs/xc/xenctrl.ml                |  1 -
 tools/ocaml/libs/xc/xenctrl.mli               |  1 -
 tools/python/xen/lowlevel/xc/xc.c             | 18 ++++-
 xen/arch/arm/dom0less-build.c                 |  3 +-
 xen/arch/arm/domain.c                         | 31 ++++-----
 xen/arch/arm/domain_build.c                   |  3 +-
 xen/arch/arm/domctl.c                         |  2 +
 xen/arch/arm/firmware/sci.c                   |  2 +-
 xen/arch/arm/firmware/scmi-smc.c              |  2 +-
 xen/arch/arm/gic.c                            | 16 +++++
 xen/arch/arm/include/asm/firmware/sci.h       |  6 +-
 xen/arch/arm/include/asm/gic.h                |  6 ++
 xen/arch/arm/include/asm/time.h               |  7 +-
 xen/arch/arm/include/asm/vgic.h               |  6 ++
 xen/arch/arm/include/asm/vtimer.h             |  3 +-
 xen/arch/arm/sysctl.c                         | 39 +++++++++++
 xen/arch/arm/time.c                           |  9 ++-
 xen/arch/arm/vgic-v2.c                        |  5 ++
 xen/arch/arm/vgic/vgic-v2.c                   |  5 ++
 xen/arch/arm/vtimer.c                         |  4 +-
 xen/arch/ppc/stubs.c                          |  2 +-
 xen/arch/riscv/domain.c                       |  2 +-
 xen/arch/x86/domain.c                         | 16 ++---
 xen/include/public/arch-arm.h                 | 18 +----
 xen/include/public/domctl.h                   |  4 +-
 xen/include/public/sysctl.h                   | 22 ++++++-
 xen/include/xen/sched.h                       |  5 +-
 33 files changed, 273 insertions(+), 81 deletions(-)

-- 
2.53.0



--
Julian Vetter | Vates Hypervisor & Kernel Developer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech