[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH v2] stubdom: Fix GCC 14 -Wmemset-elt-size compiler warnings in PolarSSL


  • To: xen-devel@xxxxxxxxxxxxxxxxxxxx
  • From: Andrew Mbugua <andrewprecious388@xxxxxxxxx>
  • Date: Thu, 10 Sep 2026 12:14:14 +0300
  • Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From"
  • Cc: Andrew Mbugua <andrewprecious388@xxxxxxxxx>
  • Delivery-date: Thu, 10 Sep 2026 09:15:21 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

A followup to the email thread with the previously suggested changes.

I have:
1. Added the patch reference to the Makefile
2. Removed the new subdirectory I created.
3. Formatted patch message to be <75 characters per line

When compiling Xen with GCC 14, I get a compiler warning originating from the 
/polarssl-x86_64/library about a memset element size mismatch:

ssl_tls.c: In function ‘ssl_session_reset’:
ssl_tls.c:1778:5: warning: ‘memset’ used with length equal to number of 
elements without multiplication by element size [-Wmemset-elt-size]
1778 |     memset( ssl->ctx_enc, 0, 128 );
|     ^~~~~~
ssl_tls.c:1779:5: warning: ‘memset’ used with length equal to number of 
elements without multiplication by element size [-Wmemset-elt-size]
1779 |     memset( ssl->ctx_dec, 0, 128 );
|     ^~~~~~

This patch introduces a build-time patch to PolarSSL that replaces the hardcoded
128 byte length with sizeof() allowing clean compilation without warnings.

Signed-off-by: Andrew Mbugua <andrewprecious388@xxxxxxxxx>
---
 stubdom/v2-0001-PATCH-stubdom-Fix-GCC-14-Wmemset-elt-size-compile.patch | 13 
+++++++++++++
 1 file changed, 13 insertions(+)
 create mode 100644 
stubdom/v2-0001-PATCH-stubdom-Fix-GCC-14-Wmemset-elt-size-compile.patch

diff --git 
a/stubdom/v2-0001-PATCH-stubdom-Fix-GCC-14-Wmemset-elt-size-compile.patch 
b/stubdom/v2-0001-PATCH-stubdom-Fix-GCC-14-Wmemset-elt-size-compile.patch
new file mode 100644
index 0000000000..3528f2817a
--- /dev/null
+++ b/stubdom/v2-0001-PATCH-stubdom-Fix-GCC-14-Wmemset-elt-size-compile.patch
@@ -0,0 +1,13 @@
+--- a/library/ssl_tls.c
++++ b/library/ssl_tls.c
+@@ -1775,8 +1775,8 @@
+       memset( ssl->iv_dec, 0, 16 );
+       memset( ssl->mac_enc, 0, 32 );
+       memset( ssl->mac_dec, 0, 32 );
+-    memset( ssl->ctx_enc, 0, 128 );
+-    memset( ssl->ctx_dec, 0, 128 );
++    memset( ssl->ctx_enc, 0, sizeof( ssl->ctx_enc ) );
++    memset( ssl->ctx_dec, 0, sizeof( ssl->ctx_dec ) );
+ 
+       md5_starts( &ssl->fin_md5  );
+       sha1_starts( &ssl->fin_sha1 );
-- 
2.47.3




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.