Re: [PATCH v2 0/5] stubdom: remove grub-pv

[Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>]

Jan Beulich, le jeu. 13 août 2026 07:54:39 +0200, a ecrit:
> On 13.08.2026 00:57, Samuel Thibault wrote:
> > Juergen Gross, le mer. 12 août 2026 10:16:58 +0200, a ecrit:
> >> Any feedback?
> > 
> > I'm fine with it: grub0.9x is really old, grub2 works alright in my use
> > cases and is maintained.
> 
> Was this perhaps meant to be / include an Acked-by: ?

Yes, it is an

Acked-by: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>

Thanks

> Jan
> 
> >> On 20.07.26 10:18, Juergen Gross wrote:
> >>> The grub-pv stubdoms (32- and 64-bit) are disabled by default since
> >>> several years now.
> >>>
> >>> Remove them in order to enable removing quite some more code from Xen.
> >>> In case someone is really depending on grub-pv, they can easily take it
> >>> from an older Xen build, as there is no Xen version dependency in
> >>> grub-pv (a version built 3 years ago has been tested to still work
> >>> with current 4.23 staging Xen).
> >>>
> >>> Note that after this series has been committed, some additional
> >>> cleanup is possible by removing stubdom libpci and zlib support, but
> >>> this will require a modification of Mini-OS depending on these patches.
> >>>
> >>> Changes in V2:
> >>> - moved one hunk from patch 2 to patch 1
> >>>
> >>> Juergen Gross (5):
> >>>    stubdom: remove support for grub-pv
> >>>    stubdom: remove support for building in 32-bit mode
> >>>    stubdom: remove building of libxenguest and libxenctrl
> >>>    docs: remove stale stubdom entries from stubdom.txt
> >>>    tools/libxenguest: remove Mini-OS specific parts
> >>>
> >>>   Makefile                                      |    6 -
> >>>   config/Stubdom.mk.in                          |    3 -
> >>>   docs/misc/stubdom.txt                         |   69 -
> >>>   stubdom/.gitignore                            |    1 -
> >>>   stubdom/Makefile                              |   69 +-
> >>>   stubdom/configure                             |   65 -
> >>>   stubdom/configure.ac                          |    2 -
> >>>   stubdom/grub.patches/00cvs                    | 1022 -----
> >>>   stubdom/grub.patches/10graphics.diff          | 2297 -----------
> >>>   stubdom/grub.patches/11graphics-keyboard.diff |   13 -
> >>>   stubdom/grub.patches/20print_func.diff        |   52 -
> >>>   stubdom/grub.patches/30savedefault.diff       |  186 -
> >>>   .../grub.patches/40ext3_256byte_inode.diff    |  114 -
> >>>   stubdom/grub.patches/50fs_fulldisk.diff       |   72 -
> >>>   stubdom/grub.patches/60ext4.diff              |  474 ---
> >>>   stubdom/grub.patches/61btrfs.diff             | 3499 -----------------
> >>>   stubdom/grub.patches/70compiler_warnings.diff |   45 -
> >>>   stubdom/grub.patches/99minios                 | 1570 --------
> >>>   stubdom/grub/Makefile                         |   88 -
> >>>   stubdom/grub/boot-x86_32.S                    |  112 -
> >>>   stubdom/grub/boot-x86_64.S                    |  108 -
> >>>   stubdom/grub/config.h                         |   12 -
> >>>   stubdom/grub/kexec.c                          |  434 --
> >>>   stubdom/grub/mini-os.c                        |  771 ----
> >>>   stubdom/grub/mini-os.h                        |    7 -
> >>>   stubdom/grub/minios.cfg                       |    4 -
> >>>   stubdom/grub/osdep.h                          |   30 -
> >>>   tools/libs/guest/Makefile.common              |   15 -
> >>>   tools/libs/guest/xg_dom_decompress_unsafe.c   |   48 -
> >>>   tools/libs/guest/xg_dom_decompress_unsafe.h   |   28 -
> >>>   .../guest/xg_dom_decompress_unsafe_bzip2.c    |   14 -
> >>>   .../libs/guest/xg_dom_decompress_unsafe_lz4.c |   39 -
> >>>   .../guest/xg_dom_decompress_unsafe_lzma.c     |   14 -
> >>>   .../guest/xg_dom_decompress_unsafe_lzo1x.c    |   44 -
> >>>   .../libs/guest/xg_dom_decompress_unsafe_xz.c  |   46 -
> >>>   .../guest/xg_dom_decompress_unsafe_zstd.c     |   44 -
> >>>   36 files changed, 1 insertion(+), 11416 deletions(-)
> >>>   delete mode 100644 stubdom/grub.patches/00cvs
> >>>   delete mode 100644 stubdom/grub.patches/10graphics.diff
> >>>   delete mode 100644 stubdom/grub.patches/11graphics-keyboard.diff
> >>>   delete mode 100644 stubdom/grub.patches/20print_func.diff
> >>>   delete mode 100644 stubdom/grub.patches/30savedefault.diff
> >>>   delete mode 100644 stubdom/grub.patches/40ext3_256byte_inode.diff
> >>>   delete mode 100644 stubdom/grub.patches/50fs_fulldisk.diff
> >>>   delete mode 100644 stubdom/grub.patches/60ext4.diff
> >>>   delete mode 100644 stubdom/grub.patches/61btrfs.diff
> >>>   delete mode 100644 stubdom/grub.patches/70compiler_warnings.diff
> >>>   delete mode 100644 stubdom/grub.patches/99minios
> >>>   delete mode 100644 stubdom/grub/Makefile
> >>>   delete mode 100644 stubdom/grub/boot-x86_32.S
> >>>   delete mode 100644 stubdom/grub/boot-x86_64.S
> >>>   delete mode 100644 stubdom/grub/config.h
> >>>   delete mode 100644 stubdom/grub/kexec.c
> >>>   delete mode 100644 stubdom/grub/mini-os.c
> >>>   delete mode 100644 stubdom/grub/mini-os.h
> >>>   delete mode 100644 stubdom/grub/minios.cfg
> >>>   delete mode 100644 stubdom/grub/osdep.h
> >>>   delete mode 100644 tools/libs/guest/xg_dom_decompress_unsafe.c
> >>>   delete mode 100644 tools/libs/guest/xg_dom_decompress_unsafe.h
> >>>   delete mode 100644 tools/libs/guest/xg_dom_decompress_unsafe_bzip2.c
> >>>   delete mode 100644 tools/libs/guest/xg_dom_decompress_unsafe_lz4.c
> >>>   delete mode 100644 tools/libs/guest/xg_dom_decompress_unsafe_lzma.c
> >>>   delete mode 100644 tools/libs/guest/xg_dom_decompress_unsafe_lzo1x.c
> >>>   delete mode 100644 tools/libs/guest/xg_dom_decompress_unsafe_xz.c
> >>>   delete mode 100644 tools/libs/guest/xg_dom_decompress_unsafe_zstd.c
> >>>
> >>
> > 
> > 
> > 
> > 
> > 
> > 
> 

-- 
Samuel
Fatal Error: Found [MS-Windows] System -> Repartitioning Disk for Linux...
(By cbbrown@xxxxxx, Christopher Browne)