[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 2/3] xen/scripts: adapt gen_compile_commands.py to Xen



On Mon, Aug 10, 2026 at 10:49:44AM +0100, George Dunlap wrote:
> Two changes from the Linux original:
> 
>  - Linux's compiler invocations end with the source file
>    ("... -c -o foo.o foo.c"), and the script's line pattern relies
>    on that; Xen's cmd_cc_o_c places "-c $<" before "-o" and "-MQ",
>    so on a Xen object tree the unmodified script matches nothing and
>    produces an empty database.  Adjust _LINE_PATTERN to capture the
>    command up to and including "-c" plus the source file, dropping
>    the remainder, which database consumers do not need.
> 
>  - Reword the docstring and help text to refer to Xen.
> 
> The support for reading object lists from archives and modules.order
> is unused in Xen but retained to minimise divergence from the
> original.
> 
> Assisted-by: LLM
> Signed-off-by: George Dunlap <gwd@xxxxxxxxxxxxxx>

Reviewed-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>

Thanks,


--
Anthony Perard | Vates XCP-ng Developer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.