[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 15/24] XSM/dummy: drop redundant return statements


  • To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>
  • Date: Wed, 5 Aug 2026 18:40:24 -0400
  • Arc-authentication-results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@xxxxxxxxxxxxxxxxxxxx; dmarc=pass header.from=<dpsmith@xxxxxxxxxxxxxxxxxxxx>
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1785969621; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=exdTnw8wAxnwKL2WEgMO2tqs2wU8iaIgCY+olaqOOdI=; b=DONCxbJeBfuy25e6KJglT1mpIFc0+dA8ENywiD8Q9k2NBi3YTyTI72ERk+9EZuDKw0JNbixMgOSC+xpnWjTu9XjOMYj5/fH+ia6wrM6Q6JMS4aL/33VUHm5MHjtcrzG8tpYI/1CGxQueKxaxkgJWCVeyRW1AqdbHncLkpJ21Yto=
  • Arc-seal: i=1; a=rsa-sha256; t=1785969621; cv=none; d=zohomail.com; s=zohoarc; b=CP9Blk9FJeGRefQp4c4yqBJdZ14hNzBaYbAHq0DfWpYvAVDPl8x8DnSEYWBbw93C+IbkRTvKnyWYLiX373qgMkE4TZVvOhBmhF96ZWJ0B4hayGl7d2/PjkWEqvfPn4J03RQQ/Ip4QQlE0AcOScGi1XOZ1pkqUBffDzh+hD8u0dQ=
  • Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=zoho header.d=apertussolutions.com header.i="dpsmith@xxxxxxxxxxxxxxxxxxxx" header.h="Message-ID:Date:MIME-Version:Subject:To:From:In-Reply-To:Content-Type:Content-Transfer-Encoding"
  • Delivery-date: Wed, 05 Aug 2026 22:40:26 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 7/28/26 9:20 AM, Jan Beulich wrote:
They're meaningless when no value is returned.

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

--- a/xen/include/xsm/dummy.h
+++ b/xen/include/xsm/dummy.h
@@ -123,9 +123,7 @@ static XSM_INLINE int xsm_set_system_act
static XSM_INLINE void xsm_security_domaininfo(
      struct domain *d, struct xen_domctl_getdomaininfo *info)
-{
-    return;
-}
+{}
static XSM_INLINE int xsm_domain_create(
      XSM_DEFAULT_ARG struct domain *d, uint32_t ssidref)
@@ -187,9 +185,7 @@ static XSM_INLINE int xsm_alloc_security
  }
static XSM_INLINE void xsm_free_security_domain(struct domain *d)
-{
-    return;
-}
+{}
#ifdef CONFIG_GRANT_TABLE @@ -316,9 +312,7 @@ static XSM_INLINE int xsm_evtchn_interdo
  }
static XSM_INLINE void xsm_evtchn_close_post(struct evtchn *chn)
-{
-    return;
-}
+{}
static XSM_INLINE int xsm_evtchn_send(
      XSM_DEFAULT_ARG struct domain *d, struct evtchn *chn)
@@ -349,9 +343,7 @@ static XSM_INLINE int xsm_alloc_security
static XSM_INLINE void xsm_free_security_evtchns(
      struct evtchn chn[], unsigned int nr)
-{
-    return;
-}
+{}
static XSM_INLINE char *xsm_show_security_evtchn(
      struct domain *d, const struct evtchn *chn)


Acked-by: Daniel P. Smith <dpsmith@xxxxxxxxxxxxxxxxxxxx>



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.