[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 2/3] xen/livepatch: Fix include hierarchy
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>
- Date: Mon, 3 Aug 2026 15:05:38 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dQhPrpdiWnaSoeNcNnfROBr+QPpTBnQIhAoLCjbz3l4=; b=R8Qlc3CZbKbCUWeHtkmzJue6ngci5xUrkSN20Km0BT/1YnQRYUPF8pxM/jfFnLAaYovCgxv4eqd0GbhSuNmRFNIL+I2ARRw0l3Km7p7e7DhQhWCekJfRm5njS/j2fMDCg6/4YSBMU4WzkMUdwLqkFsRhp6BSJQsTXsuwwWVL7EfS+49c7ZmfQoHevwqHKitvLbp/w+TFT9eW96Udfkvjhqd8OxyyMOj6G50PVC+If+XE2jXzjrDpK9KNIbOH1r+MN+YMHqJFthr6Agu6FQFbprBOTS2ghe34czD32SwRQ7WCGS84kDckjMZyxV31yw7sH+bfSAIABiOyWRisoEN7Tg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=E95kQb54/Up4zQNpaK2mkQPBjjPUTJKxWMfkPGvedy5hkuh4ZaEM79QZsq1e0xojCTuHDQuc2+CE1cgSVN914XR4hNvFL3j2NhSj1GqGqdP8Z8PKLP7+zVL5a1m44ba+azxb38Ceei9ITGeDOJh5eixA2muBWOlsz8RxLc+S7WF93BydMtKwZV+4ZTuJgZLV5OTeOkxak9utxnTmJUev9pqFwcMlVna1Zcpr9CZhDIrfw6K6732BZqeJOiFn0WkCXS0LgxrELdEN1kdT7njQxCw+ZsUzk6AWBtuVdXxUu8oOn/1og+fKlLY6jL863SPs1pCFKRLSxdBX9DLRCmjleA==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:x-ms-exchange-senderadcheck"
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Roger Pau Monné <roger@xxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
- Delivery-date: Mon, 03 Aug 2026 15:05:56 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Msip_labels:
- Thread-index: AQHdIQOIBBx6uSDlKEqW+113k5excraMcI6S
- Thread-topic: [PATCH v3 2/3] xen/livepatch: Fix include hierarchy
> From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Sent: Friday, July 31, 2026 4:44 PM
> To: Xen-devel
> Cc: Andrew Cooper; Anthony PERARD; Michal Orzel; Jan Beulich; Julien Grall;
> Roger Pau Monné; Stefano Stabellini; Volodymyr Babchuk; Bertrand Marquis;
> Oleksii Kurochko; Ross Lagerwall
> Subject: [PATCH v3 2/3] xen/livepatch: Fix include hierarchy
>
> xen/livepatch.h includes public/sysctl.h twice, which can be deduplicated, and
> includes asm/livepatch.h meaning that each livepatch.c does not need to
> include both.
>
> Comment the #else and #endif cases to aid legibility.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Reviewed-by: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>
Thanks
|