Xen project Mailing List

Re: [PATCH 10/24] XSM: make .dm_op() hook dependent upon IOREQ_SERVER=y

To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>

From: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>

Date: Sun, 2 Aug 2026 11:07:37 -0400

Arc-authentication-results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@xxxxxxxxxxxxxxxxxxxx; dmarc=pass header.from=<dpsmith@xxxxxxxxxxxxxxxxxxxx>

Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1785683253; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=oGbJXX1sOwuN6ygD60/WQFIBvc8kIT+FhnM8E4QOS08=; b=nkP994rG7e6bybsqEwslBt8M0JIQ4NEgVCNF41IGBBiWFLg4UwyX2bodRnkLKo7iQY0ie4Y9SBq0xA4OIVll7iQ9LSrdjHsgYCXY61H+srAuPR5ZwzdDntLtbZmV2hxG59hASpq/ykjER/8eooW6616p7/2M3aIyPx1jPO+oO7k=

Arc-seal: i=1; a=rsa-sha256; t=1785683253; cv=none; d=zohomail.com; s=zohoarc; b=F8rudERShobwyQAzml22u79eQoqJpuYeUFVBRoRrGH3/Akju7tILgCxvOuoUzZroUFWD0JCFs+mdW/Vc6z+ogRGH8zHv0/XQlWoOTdWeIF/gOMyQaNp29GLe4y2Z9tWMJ/75+LAAZZ3gCd8GutjY2lUbrw1BnH2HV3cEpsPpI1s=

Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=zoho header.d=apertussolutions.com header.i="dpsmith@xxxxxxxxxxxxxxxxxxxx" header.h="Message-ID:Date:MIME-Version:Subject:To:From:In-Reply-To:Content-Type:Content-Transfer-Encoding"

Delivery-date: Sun, 02 Aug 2026 15:07:41 +0000

List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 7/28/26 9:17 AM, Jan Beulich wrote:

It's unreachable / dead otherwise.

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

--- a/xen/include/xsm/dummy.h
+++ b/xen/include/xsm/dummy.h
@@ -739,11 +739,13 @@ static XSM_INLINE int cf_check xsm_pmu_o

#endif /* CONFIG_X86 */+#ifdef CONFIG_IOREQ_SERVER

  static XSM_INLINE int cf_check xsm_dm_op(XSM_DEFAULT_ARG struct domain *d)
  {
      XSM_ASSERT_ACTION(XSM_DM_PRIV);
      return xsm_default_action(action, current->domain, d);
  }
+#endif

#ifdef CONFIG_ARGO

  static XSM_INLINE int cf_check xsm_argo_enable(const struct domain *d)
--- a/xen/include/xsm/hooks.h
+++ b/xen/include/xsm/hooks.h
@@ -145,7 +145,10 @@ XSM_HOOK(int, ioport_mapping, struct dom
  XSM_HOOK(int, pmu_op, struct domain *, unsigned int)
  #endif /* CONFIG_X86 */

+#ifdef CONFIG_IOREQ_SERVER

  XSM_HOOK(int, dm_op, struct domain *)
+#endif
+
  XSM_HOOK(int, xen_version, uint32_t)
  XSM_HOOK(int, domain_resource_map, struct domain *)

--- a/xen/xsm/flask/hooks.c

+++ b/xen/xsm/flask/hooks.c
@@ -1852,10 +1852,12 @@ static int cf_check flask_pmu_op(struct
  }
  #endif /* CONFIG_X86 */

+#ifdef CONFIG_IOREQ_SERVER

  static int cf_check flask_dm_op(struct domain *d)
  {
      return current_has_perm(d, SECCLASS_HVM, HVM__DM);
  }
+#endif

static int cf_check flask_xen_version(uint32_t op)

Acked-by: Daniel P. Smith <dpsmith@xxxxxxxxxxxxxxxxxxxx>

©2013 Xen Project, A Linux Foundation Collaborative Project. All Rights Reserved.
Linux Foundation is a registered trademark of The Linux Foundation.
Xen Project is a trademark of The Linux Foundation.