Xen project Mailing List

Re: [PATCH 05/24] XSM: make .iomem_mapping_vcpi() hook dependent upon HAS_VPCI=y

To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>

From: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>

Date: Sun, 2 Aug 2026 10:56:04 -0400

Arc-authentication-results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@xxxxxxxxxxxxxxxxxxxx; dmarc=pass header.from=<dpsmith@xxxxxxxxxxxxxxxxxxxx>

Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1785682560; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=nEk+EQeINCftDeVHUH0EflRmlpsWdGR8Goc03eXOtm0=; b=DzWgvtMCbIMrAI7krK0TgLj/r+L9h6CeLRPVbR7bkiJ4jptPtMV1IrRFkBXY7zzq9SvAOlU27qq0lGtndIc1iwKLXH3rC/D/mLof8pAr+SLQyjLwtWkz5Ue/vFStz2mF9VMA3Q+60ujCon8uLil0zEMw0FpzU5/kRdg41leRgOg=

Arc-seal: i=1; a=rsa-sha256; t=1785682560; cv=none; d=zohomail.com; s=zohoarc; b=VAz/p1RK69xgKt3N5Ueaeb2Ye60bKh3LCyM31UCMlhV3/EhyHrwa+u5FIDhPVeXRm6dR/YlYaMMi0DqBOu88sFQBTn2Q9PDn1QDWLr9bYL4rAWHAUr24JjkTBvuBQNPcsSkcAtvwpuS/Vq8hWA1R4BGjlkkg2enbhVxwwvvVDVg=

Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=zoho header.d=apertussolutions.com header.i="dpsmith@xxxxxxxxxxxxxxxxxxxx" header.h="Message-ID:Date:MIME-Version:Subject:To:From:In-Reply-To:Content-Type:Content-Transfer-Encoding"

Delivery-date: Sun, 02 Aug 2026 14:56:08 +0000

List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

nit: typo in subject, .iomem_mapping_vcpi --> .iomem_mapping_vpci On 7/28/26 9:15 AM, Jan Beulich wrote:

It's unreachable / dead otherwise.

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

--- a/xen/include/xsm/dummy.h
+++ b/xen/include/xsm/dummy.h
@@ -525,12 +525,14 @@ static XSM_INLINE int cf_check xsm_iomem
      return xsm_default_action(action, current->domain, d);
  }

+#ifdef CONFIG_HAS_VPCI

  static XSM_INLINE int cf_check xsm_iomem_mapping_vpci(
      XSM_DEFAULT_ARG struct domain *d, uint64_t s, uint64_t e, uint8_t allow)
  {
      XSM_ASSERT_ACTION(XSM_HOOK);
      return xsm_default_action(action, current->domain, d);
  }
+#endif

#ifdef CONFIG_HAS_PCI

  static XSM_INLINE int cf_check xsm_pci_config_permission(
--- a/xen/include/xsm/hooks.h
+++ b/xen/include/xsm/hooks.h
@@ -79,7 +79,9 @@ XSM_HOOK(int, irq_permission, struct dom
  XSM_HOOK(int, iomem_permission, struct domain *, uint64_t, uint64_t, uint8_t)

XSM_HOOK(int, iomem_mapping, struct domain *, uint64_t, uint64_t, uint8_t)

+#ifdef CONFIG_HAS_VPCI
  XSM_HOOK(int, iomem_mapping_vpci, struct domain *, uint64_t, uint64_t, 
uint8_t)
+#endif

#if defined(CONFIG_HAS_PASSTHROUGH) && defined(CONFIG_HAS_PCI)

  XSM_HOOK(int, resource_plug_pci, uint32_t)

Outside of the typo, Acked-by: Daniel P. Smith <dpsmith@xxxxxxxxxxxxxxxxxxxx

©2013 Xen Project, A Linux Foundation Collaborative Project. All Rights Reserved.
Linux Foundation is a registered trademark of The Linux Foundation.
Xen Project is a trademark of The Linux Foundation.