[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 13/13] mm/mremap: convert mremap code to use vma_flags_t
- To: Lance Yang <lance.yang@xxxxxxxxx>
- From: Lorenzo Stoakes <ljs@xxxxxxxxxx>
- Date: Thu, 2 Jul 2026 17:31:24 +0100
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=k20260515 header.d=kernel.org header.i="@kernel.org" header.h="Date:From:To:Cc:Subject:References:In-Reply-To"
- Cc: akpm@xxxxxxxxxxxxxxxxxxxx, tsbogend@xxxxxxxxxxxxxxxx, maddy@xxxxxxxxxxxxx, mpe@xxxxxxxxxxxxxx, maarten.lankhorst@xxxxxxxxxxxxxxx, mripard@xxxxxxxxxx, tzimmermann@xxxxxxx, airlied@xxxxxxxxx, simona@xxxxxxxx, l.stach@xxxxxxxxxxxxxx, inki.dae@xxxxxxxxxxx, sw0312.kim@xxxxxxxxxxx, kyungmin.park@xxxxxxxxxxx, krzk@xxxxxxxxxx, peter.griffin@xxxxxxxxxx, jani.nikula@xxxxxxxxxxxxxxx, joonas.lahtinen@xxxxxxxxxxxxxxx, rodrigo.vivi@xxxxxxxxx, tursulin@xxxxxxxxxxx, robin.clark@xxxxxxxxxxxxxxxx, lumag@xxxxxxxxxx, lyude@xxxxxxxxxx, dakr@xxxxxxxxxx, tomi.valkeinen@xxxxxxxxxxxxxxxx, hjc@xxxxxxxxxxxxxx, heiko@xxxxxxxxx, andy.yan@xxxxxxxxxxxxxx, thierry.reding@xxxxxxxxxx, mperttunen@xxxxxxxxxx, jonathanh@xxxxxxxxxx, kraxel@xxxxxxxxxx, dmitry.osipenko@xxxxxxxxxxxxx, zack.rusin@xxxxxxxxxxxx, matthew.brost@xxxxxxxxx, thomas.hellstrom@xxxxxxxxxxxxxxx, oleksandr_andrushchenko@xxxxxxxx, deller@xxxxxx, bcrl@xxxxxxxxx, viro@xxxxxxxxxxxxxxxxxx, brauner@xxxxxxxxxx, muchun.song@xxxxxxxxx, osalvador@xxxxxxx, david@xxxxxxxxxx, ziy@xxxxxxxxxx, baolin.wang@xxxxxxxxxxxxxxxxx, liam@xxxxxxxxxxxxx, npache@xxxxxxxxxx, ryan.roberts@xxxxxxx, dev.jain@xxxxxxx, baohua@xxxxxxxxxx, hughd@xxxxxxxxxx, vbabka@xxxxxxxxxx, rppt@xxxxxxxxxx, surenb@xxxxxxxxxx, mhocko@xxxxxxxx, jannh@xxxxxxxxxx, pfalcato@xxxxxxx, kees@xxxxxxxxxx, perex@xxxxxxxx, tiwai@xxxxxxxx, linux-mips@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linuxppc-dev@xxxxxxxxxxxxxxxx, dri-devel@xxxxxxxxxxxxxxxxxxxxx, etnaviv@xxxxxxxxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-samsung-soc@xxxxxxxxxxxxxxx, intel-gfx@xxxxxxxxxxxxxxxxxxxxx, linux-arm-msm@xxxxxxxxxxxxxxx, freedreno@xxxxxxxxxxxxxxxxxxxxx, nouveau@xxxxxxxxxxxxxxxxxxxxx, linux-rockchip@xxxxxxxxxxxxxxxxxxx, linux-tegra@xxxxxxxxxxxxxxx, virtualization@xxxxxxxxxxxxxxx, intel-xe@xxxxxxxxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, linux-fbdev@xxxxxxxxxxxxxxx, linux-aio@xxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, linux-sound@xxxxxxxxxxxxxxx
- Delivery-date: Thu, 02 Jul 2026 16:32:05 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Fri, Jul 03, 2026 at 12:17:29AM +0800, Lance Yang wrote:
>
>
> On 2026/7/3 00:07, Lorenzo Stoakes wrote:
> > On Thu, Jul 02, 2026 at 09:49:47PM +0800, Lance Yang wrote:
> > >
> > > On Mon, Jun 29, 2026 at 08:25:36PM +0100, Lorenzo Stoakes wrote:
> > > > Replace use of the legacy vm_flags_t flags with vma_flags_t values
> > > > throughout the mremap logic.
> > > >
> > > > Additionally update comments to reflect the changes to be consistent.
> > > >
> > > > No functional change intended.
> > > >
> > > > Signed-off-by: Lorenzo Stoakes <ljs@xxxxxxxxxx>
> > > > ---
> > >
> > > The vm_flags_set() cases below spell out vma_start_write(), but the
> > > vm_flags_clear() cases don't?
> >
> > Yep as I said elsewhere, implicitly taking the lock is terrible and me doing
> > this is completely on purpose to get rid of that :)
> >
> > But I haven't been clear enough clearly, so I should put the argument as to
> > why
> > that's ok in the commit message.
> >
> > Will do so on respin.
>
> Makes sense, thanks for spelling it out! A short changelog note
> should clear it up for me :D
Yeah absolutely, that's necessary and was an oversight on my part, will correct!
Thanks for your great review here, much appreciated! :)
>
> [...]
Cheers, Lorenzo
|
