Re: [PATCH 2/4] libxc: drop size parameter from xc_flask_context_to_sid()

[Anthony PERARD <anthony.perard@xxxxxxxxxx>]

On Tue, Jun 16, 2026 at 12:00:29PM +0200, Jan Beulich wrote:
> On 16.06.2026 11:19, Jürgen Groß wrote:
> > On 16.06.26 11:01, Jan Beulich wrote:
> >> Nul-terminated strings are passed in all cases, so the strlen() can very
> >> well be invoked by the function itself. In preparation for a hypervisor
> >> change also include the nul terminator in the size calculation.
> >>
> >> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> >> ---
> >> Ideally libxl_flask_context_to_sid() would follow suit, but aiui doing so
> >> would break its (stable) ABI.
> > 
> > You could use LIBXL_API_VERSION in libxl.h to modify the interface for new
> > libxl versions. See how it is done e.g. for libxl_domain_create_restore().
> 
> Question being - is this worth the effort?

I don't feel like it is.

Cheers,


--
Anthony Perard | Vates XCP-ng Developer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech