[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 08/25] xen/riscv: introduce guest riscv,isa string
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
- Date: Wed, 1 Jul 2026 09:44:51 +0200
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:In-Reply-To:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID"
- Cc: Romain Caritey <Romain.Caritey@xxxxxxxxxxxxx>, Baptiste Le Duc <baptiste.le-duc@xxxxxxxxxx>, Alistair Francis <alistair.francis@xxxxxxx>, Connor Davis <connojdavis@xxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Julien Grall <julien@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 01 Jul 2026 07:45:11 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 7/1/26 8:22 AM, Jan Beulich wrote:
@@ -94,6 +95,9 @@ struct arch_domain {
struct p2m_domain p2m;
struct paging_domain paging;
+
+ DECLARE_BITMAP(isa, RISCV_ISA_EXT_MAX);
+ char *isa_str;
};
Why is it again that both the bitmap and its string representation need
storing? In the end they provide two different sources of truth, as there's
no guarantee that they'll remain in sync.
isa_str is needed to guest device tree to tell which extensions are
supported.
Sure, but does that need storing over the lifetime of the domain?
Considering my answer to you last question here ... then there is no
such need.
Can't
that string be allocated, built, used, and then freed while DT is being
built?
Agree, it could be done in this way.
Would that string be used at all for toolstack-created domains?
... No, it won't. This string will be created by toolstack. So it could
really be dropped from arch_domain.
Thasnk.
~ Oleksii
|
