[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/2] hw/xen/interface: Remove pre-C99 checks


  • To: Bastian Blank <bblank@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, qemu-devel@xxxxxxxxxx
  • From: Philippe Mathieu-Daudé <philmd@xxxxxxxxxxxxxxxx>
  • Date: Sun, 14 Jun 2026 18:40:44 +0200
  • Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=qcppdkim1 header.d=qualcomm.com header.i="@qualcomm.com" header.h="Content-Transfer-Encoding:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"; dkim=pass header.s=google header.d=oss.qualcomm.com header.i="@oss.qualcomm.com" header.h="Content-Transfer-Encoding:In-Reply-To:Content-Language:From:References:To:Subject:User-Agent:MIME-Version:Date:Message-ID"
  • Delivery-date: Sun, 14 Jun 2026 16:41:10 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 13/6/26 20:13, Bastian Blank wrote:
On Sat, Jun 13, 2026 at 07:51:50PM +0200, Philippe Mathieu-Daudé wrote:
We mandate a compiler supporting C99 since 2019-01-17 in
commit 7be41675f7c ("configure: Force the C standard to gnu99"),
thus supporting flexible array members. Remove what is now dead
code.

+    uint32_t optarr[0];

This is no flexible array member. "optarr[]" would be.

Oops yes you are right... This is what we want here.


https://www.gnu.org/software/c-intro-and-ref/manual/html_node/Flexible-Array-Fields.html

Or are you talking about something different?

Bastian





 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.