[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] arm/gicv3: Detect normal NC ITS command queues
- To: Mykola Kvach <xakep.amatop@xxxxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Fri, 15 May 2026 12:02:21 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=gmail.com smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2vinw5w+7JZxyZ5ZVD3zdPrApkvslbuawIliYH6+lY4=; b=DQYUO3oPpAZa7un5vcZJpPE9tAF8JNNzx7Ph/7APJHGrfgUDxq25BYSMZOMng+BepRDxfeSU5HtRvmXdVwn3GrYqF+L+jrS53YMLDs8st7q3WpmnQVc3JXX/cykqLJfVYE3H5HiLVZRHrZTR8FkHYerjvrLRJXmDDZnRVWYr4AYI5CmhLgw/8jGqr15QQD9pENWPVn9/OEVXCoznhQzDdeUMjKluzh93fLeQH202XiCBtGjmkfSjTr4YFAnokEkNE665EUlfrUzleDuCM9l1dWPktCMrGPXE9Yfr3PYFLFs+hISwki/hBCiA1ApFF0q01ac8JY8iLrSeKzkwIWgUYA==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2vinw5w+7JZxyZ5ZVD3zdPrApkvslbuawIliYH6+lY4=; b=piKTlCar/2CONK68aCWW8zrJM/MRyeuOrRo2LBQ2aOgwoauTA5scpnZvIzwXb/uEEDnAM0/05ejvMO44pwCctjfylWCXgrflr7UKIZS/lgKA/3AazeZDVlOI3QoABLhW+5GUP7vQ+iRy9xXRln/n5cTH0qlFrqYD3KUjkjCdXr11bmo6T8x9TdE6iw0Xyuzpi14dCgWablA9x5bQN1ZDzipkNvxE9OINA2o3VJy91steYn9Kw6lrHp9BbPlKCs3b1YPz0OGlR+bvNp8doqzSuRb4Fq5RzCnPqmvZINhnjjx2Y6waTvI9sFmduEAyOmAeVhE6hN6V3ojqDEA93XquTA==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=ZEoF3oRK6Rfy4n8Jl2CvrNrVEquuKCp3RknHvPGbagAAjN5veINlJ3CQa7hfg2lyEVGB8c8c1nHKLdKFUmlNTGDoZEKlq3ogiwKuncERoSftbaPZRFw34QOXQYl+saxpzuXDOfJUsIQyIXpYy/OMfniX8+yoyswnqi/a6YQdIcWUufpIuOqAspx1vooDaL8QH180P0ExQveP8gofKJmjhZx3hIO+tgoGL4Cv09YKZM+4quXiSbTtNGanXiaezQtOS9GHn7MYldPf7tKEXR2BrWH7IU2I/ZTEWH2USyXHjBd3B28W5Msuvb56eBmYlevyUK7GZMseSC9zxzrWWC0o/g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=EUxcYrqieXmGZkzox+X1vui//aqsb9UVE5kkOB96lhTpZUcCLMges7cZ1qqVJ0+cbBvLPhIApFM5wWWekeRUseiA0ElSKQxaXU5EfvL8smdYmrf1QWZ5tHsGGxfLPKliIkiO+OgNCAuHyxgm5T+1rVfY2AgIs/CDU8L5iX0QnGdZeVL1i9qnGNCRkzf2+VyEqlVIZlRxLe9SRlRwgvOdYo++VZO43amTHZZt6F+U8bV6dhKHnLlkEaSxDrOBGhU/l+ZZLaxjRmMxa8yOQl6agUPE5eJHVmU+9uWsKpGE9Tvsq57JjwPRCrT+zG9lfwaRREtQPuDwOAHKtGJ+iwPaZw==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=arm.com header.i="@arm.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"; dkim=pass header.s=selector1 header.d=arm.com header.i="@arm.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Mykola Kvach <mykola_kvach@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Fri, 15 May 2026 12:03:34 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Thread-index: AQHc5E+Snj3ItlO/Dk2J2zISdlUxorYO/JuA
- Thread-topic: [PATCH] arm/gicv3: Detect normal NC ITS command queues
Hi Mykola,
> On 15 May 2026, at 10:40, Mykola Kvach <xakep.amatop@xxxxxxxxx> wrote:
>
> From: Mykola Kvach <mykola_kvach@xxxxxxxx>
>
> GITS_CBASER.InnerCache uses the GIC BASER cacheability encoding.
> Both 0b000 (Device-nGnRnE) and 0b001 (Normal Inner
> Non-cacheable) describe non-cacheable accesses to the command queue.
>
> its_map_cbaser() only checked whether the shifted field was zero,
> so an ITS that reports Normal Inner Non-cacheable would not set
> HOST_ITS_FLUSH_CMD_QUEUE. Decode the field before comparing it with
> the unshifted enum value, matching the handling of ITS BASER tables
> and GICR_PROPBASER.
>
> Fixes: 8ed8d21373be ("ARM: GICv3 ITS: map ITS command buffer")
> Signed-off-by: Mykola Kvach <mykola_kvach@xxxxxxxx>
> ---
> xen/arch/arm/gic-v3-its.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/xen/arch/arm/gic-v3-its.c b/xen/arch/arm/gic-v3-its.c
> index 9005ce8ce5..7560d46c6d 100644
> --- a/xen/arch/arm/gic-v3-its.c
> +++ b/xen/arch/arm/gic-v3-its.c
> @@ -424,7 +424,8 @@ static void *its_map_cbaser(struct host_its *its)
> * If the command queue memory is mapped as uncached, we need to flush
> * it on every access.
> */
> - if ( !(reg & GITS_BASER_INNER_CACHEABILITY_MASK) )
> + if ( MASK_EXTR(reg, GITS_BASER_INNER_CACHEABILITY_MASK) <=
> + GIC_BASER_CACHE_nC )
> {
> its->flags |= HOST_ITS_FLUSH_CMD_QUEUE;
> printk(XENLOG_WARNING "using non-cacheable ITS command queue\n");
> --
> 2.43.0
>
>
Looks ok to me
Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>
Cheers,
Luca
|
