[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v9 12/13] xen/arm: Add vPSCI SYSTEM_SUSPEND policy
- To: Mykola Kvach <xakep.amatop@xxxxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Fri, 15 May 2026 08:17:21 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=gmail.com smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lBJ1CBqWZ6QP29mG2UV2XsRVElOjeAkGM5wBc84baSA=; b=WNTsyesyxLehph8OnNbk0JrCkvlXN8hVawQF2rpePElwQUYTIWPI7enYahD+THG/xDu9OCEZOLet8BNKdupepI1aJO31dzHL4ZvxAnhm/hfVRnN+uGGiyhadZemzq6x2/k2IA6poN6/KobYu8jo8jYjIcta5NfBReT742bppdEYfE3O2yx5Gq1vS82pGPiUKhvDIfYVYBB+0KDptL79+YrC88L1e8m90qAxT/P68gfkBPj6FHt2AKxS6ySvEqxHNe/3V9E+fEWV5pRkxwcnbk8LyX4lYsIGqPC/iLjLydRPQu5FvMyjZlsXIlzwtYoLYGdybD26p3N4PQfmW7WkzHw==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lBJ1CBqWZ6QP29mG2UV2XsRVElOjeAkGM5wBc84baSA=; b=Gf8oRLpTHXLUiOezthXxtYesmc2okZo228qy68aErQ9XlZNv7K6/Fv7sj+jdEr2ZcKHwFXYqLUpYess+iHHU99do+ZZExwO2IsaP6+HBwCcuJbDg2XTivKBLLN1AEWw7XnxJrV6my02wn63Cv2tlVKovXWat+LGkUZY31Wg05q6B+n551FPrXkyCx1+zN8B8iM7HH/C58ssa8wz+6kUKZUT8H/foThChaoWYL3vH9uQwLaCHD5hZPzp/T5deZfkA3t/kfsdaSnjpY8nKMqya9jdWsToQQOflmTW45AcY078FU3FVNIJ5D2vKq0K/wmFWHcOhlS9SPxKAD2PVkO+W3w==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=C0v+zah5sym6RqmCYnsPjVM3Cb8im42IGWWdMOK6o60tJjA8/qvnCqGQp7+A1hCHpkMikdX2bz+aAchKfC+OEZezU0qn1o2kgd7+67cZNEG25mQODKtw7Au+stknN8ta09oX+GF2um6tvBlj0x84QHTe59MzxZ4xKJajPP1+4k5WxMkaY/ZwkGwr72i/8dbxfmUsh2Cb0SAlZUy0foa6gmyR/xe1iTHlvsAXG0JGBCBAWfkurY0ENN+4p2JLCrCvkFQnbHOENIH6f46b2+lgGEf2XTfNUHFFw92RiMobS4PxQgPHFdGGp1AcN3YkP535bE7hxf03Lx0CUkZvHlQ5vw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=d1ViQGnIg2Lm8eLGQrsg9eU4TnTh0gnES3IqM7zQm5k1OCII479WdScBulfqlVOBdxNMJ5B2/Ar60zmwhY2gwPbR1N8CxAzRHvY4GhDQXWLbTeLkoE8N86WRqhhlzOr6U1F/lHJfgXgMZIa+dGsC0cgO8u5+ESjM5zlaENZsrhi1OeF0KeztwG0G6bnXUi8N32QNi0h3NhXVfnb5GuKL/VK9eeKA8Zn9Eh08fCen73q4LvQJhGyqO1xUUd9E2nU3L6XKwLFnZVjhw1WiA+rniyTymk5Lff4SyCXaD+UGmVZa0454JgebSfxuyVlOU8imEfd5dOOGmWuYD55nuw1New==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=arm.com header.i="@arm.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"; dkim=pass header.s=selector1 header.d=arm.com header.i="@arm.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Mykola Kvach <mykola_kvach@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Rahul Singh <Rahul.Singh@xxxxxxx>
- Delivery-date: Fri, 15 May 2026 08:18:42 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Thread-index: AQHc5ENAW2MQeYfyn0+JFGvrwQ6/UA==
- Thread-topic: [PATCH v9 12/13] xen/arm: Add vPSCI SYSTEM_SUSPEND policy
Hi Mykola,
apart from Jan’s findings this looks ok to me
> diff --git a/xen/include/xen/suspend.h b/xen/include/xen/suspend.h
> index 6f94fd53b0..a941331035 100644
> --- a/xen/include/xen/suspend.h
> +++ b/xen/include/xen/suspend.h
> @@ -6,6 +6,8 @@
> #if __has_include(<asm/suspend.h>)
> #include <asm/suspend.h>
> #else
> +struct domain;
> +
Just this one isn’t mentioned in the commit message.
With Jan’s point and above fixed:
Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>
> static inline void arch_domain_resume(struct domain *d) {}
> #endif
>
>
Cheers,
Luca
|
