[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86: address Misra C:2012 rule 8.4
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
- Date: Wed, 13 May 2026 23:14:50 +0200
- Arc-authentication-results: i=1; bugseng.com; arc=none smtp.remote-ip=162.55.131.47
- Arc-message-signature: i=1; d=bugseng.com; s=openarc; a=rsa-sha256; c=relaxed/relaxed; t=1778706891; h=MIME-Version:Date:From:To:Cc:Subject:In-Reply-To:References: Message-ID:X-Sender:Organization:Content-Type: Content-Transfer-Encoding; bh=PTvjraaklV2YyLSuhdYYWG+LojtBf4e8CWfb3/VE0nw=; b=jvkL24C+mMhD3da7gFmmBbC0eeQ3jx1lKWan3FUn3YdE2/ZZOvBJfuVqKytc1yI51M/T M6eWcAkrQ5M5Uo2ygPAJ+S5d73olTQuGG6DcQ7qJyKgNduI76IOtF2HqynCQHFVbvl6Yx r4m2wY1oCd+2uEyqjipn6tTANaIYGvhUC3PtZmHM6R8Y/LYcaMsATzoNhpwoKhiL4btx5 ajMG4BPqIDERUzTTCUzNYGcgsgiS16Ux1oamreNwcXG0sLxK7WdwRjU2SZ3TRdyerfblv QKKCEXzgRdljrTG+sFI729HtbKPtThs6KUVbiaehSLiJb7KV0UkiR5msMAWU68qAONYJg 2gMMD3gdH4R5kzWcvgVrdDf5UWkQ9OTGN66eclFzRzQq557fnL5khQdG6oqSU5Y/MDQgV Kuug1ted08Dke1i7aIbvf6OJ8pzvvk6D0hhSOu3NhGDkgGyvEpZ/VpU0zywG4Hl4Fa2pv TQoVum7BQTe1JjXOOLYSTO1W38Rkzs/SK+5uQHkwyx7Tveyiow67BbV+/sr6tLZY6HxSE N3Jb9ezc5Pb0s5dcG2ic4czfFzgZFUvOShsS4hGPzxizj1wW+omcScUYOPdTVAt0yFSAF 4tCc4rtwl18gJWJr0vE8iDfuAdYh3Y61fQeSyzd52LFmY0KiFNaIbHtxIFN/B64=
- Arc-seal: i=1; d=bugseng.com; s=openarc; a=rsa-sha256; cv=none; t=1778706891; b=CLrKCVqiK6WnDWdEZDlJCkTOQWJgFMl5AkDPK/8DP9wyDTvzdTfuemfRjEl0HDfO/NXV t9yqo/c7yWjcUuU9HlJWDTy/34A/3WxbxAMQY+igRoGoVD6D9Sx2UhNCgzm+xTNF0k3R7 VyoNHaZZbpGHSBBcfgw8K65jtveBDVnGdI6l1LZD+cPNi0ChuyEX66I6cMnAOWnnrgmPq OmEKlqDn3Fmfy9y7swZ+BCLCxKPrKbLPesTYywurs2Yb3C0akzdY4vWRQjmmdldanjhJe gGqN8QCklJV5O88LXHBWd/TdbPMYAHl2CQ8v87hSx1m1GTxcpf+FSNKAWiinP5A2Z1dj2 RY2/yHwk8Q7ia2uPmiEzV4chk3yief38u4n6kC51R26m/ouTWBNw6WCqy+UafqiqJ7+P0 IUtSTVVJxRuRpzeD/5DFUDx7/5GcVRX4tNu0ky5ll2ZeLnL8xqaAt9LtHpN/kquoJrulP ShfDACX0YAVeKCpFxzIbQr0U46bEuKDm1/3zOi3B/W+CRxzIWGdxX0k75tH88BHjrGCH/ hLNz7VvHUpluayFGuOwGDLMvvkOOa6Sp8XAv6/o5qk7IE0VhF7jfa5WM5T2Y4ogMHl6P3 cHAspD/z8oT+4Z+jzwwPog4Hw11pfJO27eRUWOnR0j2iIRiPgy8TKiUaozS4NmM=
- Authentication-results: eu.smtp.expurgate.cloud; none
- Authentication-results: bugseng.com; arc=none smtp.remote-ip=162.55.131.47
- Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Teddy Astie <teddy.astie@xxxxxxxxxx>
- Delivery-date: Wed, 13 May 2026 21:14:58 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 2026-05-13 16:03, Jan Beulich wrote:
... ("A compatible declaration shall be visible when an object or
function
with external linkage is defined"). Three variables lack asmlinkage
annotations.
Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Reviewed-by: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
---
https://gitlab.com/xen-project/hardware/xen-staging/-/jobs/14351897188
(covering more than just this)
--- a/xen/arch/x86/guest/xen/pvh-boot.c
+++ b/xen/arch/x86/guest/xen/pvh-boot.c
@@ -22,7 +22,7 @@
/* Initialised in head.S, before .bss is zeroed. */
bool __initdata pvh_boot;
-uint32_t __initdata pvh_start_info_pa;
+uint32_t asmlinkage __initdata pvh_start_info_pa;
static multiboot_info_t __initdata pvh_mbi;
static module_t __initdata pvh_mbi_mods[8];
--- a/xen/arch/x86/guest/xen/xen.c
+++ b/xen/arch/x86/guest/xen/xen.c
@@ -40,7 +40,7 @@ DEFINE_PER_CPU(struct vcpu_info *, vcpu_
* 0 vmcall
* > 0 vmmcall
*/
-int8_t __initdata early_hypercall_insn = -1;
+int8_t asmlinkage __initdata early_hypercall_insn = -1;
/*
* Called once during the first hypercall to figure out which
instruction to
--- a/xen/arch/x86/pv/hypercall.c
+++ b/xen/arch/x86/pv/hypercall.c
@@ -180,7 +180,7 @@ void pv_ring1_init_hypercall_page(void *
}
}
-void do_entry_int82(struct cpu_user_regs *regs)
+void asmlinkage do_entry_int82(struct cpu_user_regs *regs)
{
if ( unlikely(untrusted_msi) )
check_for_unexpected_msi((uint8_t)regs->entry_vector);
--
Nicola Vetrini, B.Sc.
Software Engineer
BUGSENG (https://bugseng.com)
LinkedIn: https://www.linkedin.com/in/nicola-vetrini-a42471253
|
