Re: [PATCH 1/2] kexec: kexec_crash_save_info() vs Misra C:2012 rule 8.3

[Stefano Stabellini <sstabellini@xxxxxxxxxx>]

On Wed, 13 May 2026, Jan Beulich wrote:
> ... ("All declarations of an object or function shall use the same names
> and type qualifiers"). The declaration doesn't use the typedef, so the
> definition shouldn't either.
> 
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>

> ---
> Really, is the typedef of much use? I.e. can't we drop it altogether?
> 
> --- a/xen/common/kexec.c
> +++ b/xen/common/kexec.c
> @@ -333,7 +333,7 @@ void kexec_crash_save_cpu(void)
>  }
>  
>  /* Set up the single Xen-specific-info crash note. */
> -crash_xen_info_t *kexec_crash_save_info(void)
> +struct crash_xen_info *kexec_crash_save_info(void)
>  {
>      int cpu = smp_processor_id();
>      crash_xen_info_t info;
> 
>