[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/5] x86/time: move BCD_TO_BIN() uses
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Wed, 13 May 2026 10:56:21 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XP3WQuQURq4bqXMRqu2WUgpsN5UQQNKBcWqSipehal4=; b=izeIzFEIiNaZ0QOnwhYx34EuSJyq/RwJHDy2m+K+1y/ohRcGxW9ECfXkNHXWXXHsjRbtYiK7t10ObQOApTPWYGC7Q9VBsVRNR84GDmtWzyGCVARn4n09T/zHGwCxSdqdBOSpq8eavG1jVA06gVLmazh5b9pgsz4KzCn1/ze9IRnx/x+ZwjdhD2X1p97pJ0uOsBXEiWarjGe/vFGtikqUy/fWFoPrAGsQG3oD16uWPIhAkNyRLop4hKclGfd/s7C8RFFpYitCPT2XqdtyH+TQSg5rZLj5K3fxqwPs7VlIVFRZRIKmE4oTC3A0qZUeFA+euY6htpMBTX3FHLlMH/Vm8w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=GSv8EA90mkhayk/T4EQY5UPgZUe+DW3W84OjJBKXMs9sUCkVl0W1BVK04w6H9rrcBBmtfREsLuUpUNTM7VyKDcvCaXN2sBS2+KgQGaKjo4hZZQOYqwElZL7Kf8tAXd/dd5CxVAh4KFbAVFpauO4AmfHKAbZanLMxtHLd016bWf3VHX8KPzqIhewxwXpWHNO5DZgCkbBeVtrKaB4pAV8wJLCrMU+9ulTynW0m3FVmMm13xALsl8VCj7dck5wvEJi/YwPdwmrECsfIw7UHmYKMJ+aUdVBpkov6nR0dowwzuk4EItm80m5TXHhs+ZiDS757jO89ernkodseP4OY7lyuHg==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Teddy Astie <teddy.astie@xxxxxxxxxx>, Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
- Delivery-date: Wed, 13 May 2026 08:56:32 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Tue, May 12, 2026 at 04:59:03PM +0200, Jan Beulich wrote:
> ... outside of __get_cmos_time()'s locked region. There's no need to hold
> the lock for these computations.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Acked-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
I had the same thought about moving the conversion out of the locked
region when reviewing the previous patch.
As noted in the previous patch, we should move the conversion of the
century field with the rest?
> ---
> How come RTC_ALWAYS_BCD is compile-time constant 1? And then even with an
> inverted comment? Looks like we've inherited this from Linux, and even in
> Linus'es current tree it's still this same way. Yet all half-way recent
> chipsets I'm aware of properly implement the DM bit in reg B. Might this
> be another 32-bit leftover?
*shrugs* I don't know. Seems like Linux is still doing it, so it's
likely safer for us to continue doing it also? We had no reports of
it being problematic, albeit one could argue it would be best to
prevent such reports by doing the right thing.
Thanks, Roger.
|
