[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] xl/parse: mark as GNU source

To: Jan Beulich <jbeulich@xxxxxxxx>
From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
Date: Wed, 13 May 2026 10:54:14 +0200
Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=vates.tech header.i="@vates.tech" header.h="From:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type:In-Reply-To:References:Feedback-ID"
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
Delivery-date: Wed, 13 May 2026 08:54:21 +0000
Feedback-id: default:8631fc262581453bbf619ec5b2062170:Sweego
List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Wed, May 13, 2026 at 09:37:02AM +0200, Jan Beulich wrote:
> Very old glibc (2.4 in the observed case) declares strndup() only when
> _GNU_SOURCE is defined.
> 
> Fixes: ad860c6454ba ("tools/xl: add xl commands for xenstore quota 
> operations")
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Acked-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>

> ---
> This follows what xl_info.c and xl_utils.c already do. Question is whether
> instead the Makefile would want to uniformly define _GNU_SOURCE.

It would probably be ok to do so.

Thanks,


--
Anthony Perard | Vates XCP-ng Developer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech

References:
- [PATCH] xl/parse: mark as GNU source
  - From: Jan Beulich

Prev by Date: Re: [PATCH for-4.22 1/5] x86/time: use RTC century byte when available
Next by Date: Re: [PATCH v6 2/3] arm/mpu: Introduce `v8r_el1_msa` device tree property for domains
Previous by thread: [PATCH] xl/parse: mark as GNU source
Index(es):
- Date
- Thread

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.