[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen/arm: sci: Don't create a domain with unsatisfied user requests
- To: Michal Orzel <michal.orzel@xxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Tue, 12 May 2026 08:53:00 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=amd.com smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cSvijUsJe/UOwM67snX7fIDYWf5TwmyPin4/myZJ2io=; b=c2XmONMhirWN6118UC/Xhfyb3cOg4MYfAvnOhHb3GBM1Dg4WRw22tNGexvoQmgCScjgivv4U3gLvTxHbyQt5NQNBON83It17gpVp4dJ9xEg8W1L+INy4b1dWcjvVFmnERsHH1BFN/vY7DZiIZROI7i29eMzr3UWfXckWTiZ81CicaQwHUwSoZqJ00RrHf343KQQQzm4h7rPBMKPO8AYaZgaI0BfN1jL3ePk5ezqtpWwsAn9xUoR37Iyl1J+eIP0IK4/StY2GqLXG+wHt0+FOX21qU34mRYduKFcmdofqbt2IYyPeUbVOtn0p9GmEW9sdAhS8GH2GgOzI56S/MJJK/w==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cSvijUsJe/UOwM67snX7fIDYWf5TwmyPin4/myZJ2io=; b=H85SI1+HQdC2h0lf6SlcxL1JOjf+mv+AI12fA9O0ll6c82+iDCELn8x974uECWgYA8kH4qdcJY7ydk6/o2UuCPi/7jkL/n2gWzmgF8tdRo25a9sH4ySiRVt+Nnsxw6KFWTk6rZmtNKvEx6gsCPVXmPMcGFZOmmoa+aCcPV+rPWN0k6PL1YAc/mhIAmPhlNfj5bD6dfb3qzMrHv7T8ijuxk0JYl0HEFIt4obuDZKw/Z0laBCL+v9qsGfXLpulVgBnDyjZ0zRtGlViMcZhuPQlRjsv25w93hYgffTcWHxXgEFyH2mAilaiPgYxaJXhhBfwWTXjBcFOG1nCWffw8zZ8tw==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=pBj5FEHuO/xXKcFRZ3w7q85U8tNHmqzp+a9QSdToxUfm6VulGwfX93NlgXozuC3I3tzerTKvemUTqaVsGXv1+/q/ylakFiGzrQUjRCoFz2HZpm9+s82s+OCxZmFv/uyCKL4sTnPUoCe+RJyS3S/n0o5TAhV8yJKdV3GKAJ/1MrgVWgFSuOCSUfBx9TOE//PHWKwEljA6eQmUcsxE1BFEwfi3V9KarlWnx+zUFSnyBBSSfRx6zADb2eT7QHkinumYM0iFftdpk+Cy3RYYKNAfzZ6ESjU7ny6kBEa6N6Egbo/Bip3gNkfhByrrXaZwGg+eYNrTV3JRIPhAOr0LaeiI9A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=K2P4olRIsemva2iDEN9/jKFRKwp4mbGX55ptazMRHCWBVgfAG4SUZHcnhX6yHZOPotml4FuoccYUx4SSngzhkAZ7PN/H+NsA4Jwpyu2pNDRKnRH+RFLguiOcM5+OfcIXg8ETNYFQeEaJYploJlfPLRbKmeEB/zyqSCj4EFGX96YikEr511cIgLlsJThtSSa26gLGtexAK7Cx7IafcPxWHbedQYUeGyM1KTCj2CJGSKBPQQVIU4SzaQzQgjsnoIbxoDYFhm5UBHVFAorXsjaoOVMf22v6YzGjeXrFeZyy6bxRKsNpT5oI2WuLlkz59M68SVrruDw9n91GxS1flXWh7A==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=arm.com header.i="@arm.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"; dkim=pass header.s=selector1 header.d=arm.com header.i="@arm.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Oleksii Moisieiev <oleksii_moisieiev@xxxxxxxx>
- Delivery-date: Tue, 12 May 2026 08:54:35 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Thread-index: AQHc4eeP1O8mBXB1rk+o//qB93qmFLYKFYUA
- Thread-topic: [PATCH] xen/arm: sci: Don't create a domain with unsatisfied user requests
Hi Michal,
> On 12 May 2026, at 09:14, Michal Orzel <michal.orzel@xxxxxxx> wrote:
>
> On Arm we stay on the safe side and refuse to create a domain on user
> requests (e.g. via xl.cfg, DT options) that cannot be satisfied due to
> the feature not being compiled in. SCI fall through the crack and does not
> adhere to that i.e. a user request for SCI type other than NONE when
> CONFIG_SCMI_SMC (and thus CONFIG_ARM_SCI) is not set would be silently
> ignored. Fix it by not allowing anything else other than NONE if the
> feature is not enabled.
>
> Fixes: 10e7473d6024 ("xen/arm: scmi-smc: passthrough SCMI SMC to domain,
> single agent")
> Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>
> ---
> xen/arch/arm/dom0less-build.c | 11 +++++++++--
> xen/arch/arm/include/asm/firmware/sci.h | 5 +++++
> 2 files changed, 14 insertions(+), 2 deletions(-)
Looks ok to me
Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>
Cheers,
Luca
|
