[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 2/3] arm/mpu: Introduce `v8r_el1_msa` device tree property for domains
- To: "Orzel, Michal" <Michal.Orzel@xxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Mon, 11 May 2026 10:53:57 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=amd.com smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BngnCWkypmX6r8VHDDEVwfpGPAPJFtqfXcW2ZXtgsPA=; b=PI0Fh/eoohoJH9nWL/g1qrrtrARTUb5B8KSznZ2pzuCtf8p2R+Fb4lenP6HVe6qRtxpQrJlYfblUgbHVRJDn5nsStAeJHByVslvN6YpKONJlbwG0aQP0zAO5LFifxpJXJuIQ5tIWgBuBNt8Go6fQCOT/Nwq/YvkDyDAVCbSxbVzQzJ2B06b+OEeNuKu61glVJft0TeuOvhQ72K90HTJr4/xJ0dhWq13wXp6ZuwR1atltpShE4PklTdsESBOJaB9BuYODTGpHsVFBUVUlpqImEyhOidls+qPuhtX1OHktgmx6LPabIKgCOeZIV9RiRg3BcZK+zyKsRfvCthQ/1va2iA==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BngnCWkypmX6r8VHDDEVwfpGPAPJFtqfXcW2ZXtgsPA=; b=w/KY0LgeTlgR7GTg4l0OCCd1924F7aapa0Ymlano4yR2vqlOmLIIDnQSvnaN1L3MojKxjFzXtQQg4rvJWFaCLiv6GoTA21Pt/wwoskYIP0IKtuVsykGGrjNNniEcg/b0P9QyOcoAzLrY9AfkVC6IogZnyeA2yvT/QJNERH5BlxD4aGrbD6WU6rmCBj6N162wLC8HtMzz6It5x60R1bYK9vSYKndb7IninvaEPdzbUvogZsxboHM8cGeAbAnbO+xkL4qUR01cZ6ALQdIPrQiq6UxFKMICkskZCfgky6ciH8VPsFvE6qAlEUlEUCEGW1CeBDmgIjfpKbydgATWCrHXmA==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=OrFtmLx1/X9IwDslsFEECEVhHfIK6V/14nXaTix41F+ND7QSX+0qeWtqJPuGDoCnPxLCYktB0IpNCuc5/DjpbL2mHrOoPsQMUwfDklW0OcdNh6TNFYaVYx418QS1ANm0Vz/hVY9dqXC/giTa7CGTdIrwZe09Cq//4rrwqyImAFTYgDl4kEffwbR2cVlBHcWYkgOz3F0bL9lzIuuvUJgmIDCE42Lea+eeyvV9q74Hpb5PF1jK0lWhPDyqwpmiJ1EKyR9z98pSGAyg3/xOR0oee8Uv1vTvOpUnurkMOUtVjf1YFXbjYjHzMM6ku4YSvVrtRbRH2YlxjHTAQfboVrnl8g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=NCC4jsv4s+s6fNtfmGQH57Z3JqF+npion4puqaDKNEc2temY/N1I6BdaLeWRuQPZj7IVfpKopLNwhvNhVG0/+rcZnglZoFX3i3mLDxMYmxNQOnDCPjmZSA2BuBF1Crd6z8G/lTQVXw8AYtNz0VvIlMwXbZlJZSWn52z1DlGI2v6gAjGqfqRqXh/8pevb1v4rHzUcyUW1tVMQFz54WEqAnUudrJhZwPNv6/Gysoyf/f80T73meMJdOm5fax06NXwGIsiepun4YoJy0+nVPg6LbVzl+7d3S4/2d86+RQfwvQHZYk7j7J33IcGk7EloHYzuFzBVK/LCa75i0CtOMkHAuA==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=arm.com header.i="@arm.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"; dkim=pass header.s=selector1 header.d=arm.com header.i="@arm.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Harry Ramsey <Harry.Ramsey@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Mon, 11 May 2026 10:55:17 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Thread-index: AQHc3vfGpFkxMscyakiMWMN4gJbZfLYIoFeAgAAH44CAAAHaAIAAAMeA
- Thread-topic: [PATCH v5 2/3] arm/mpu: Introduce `v8r_el1_msa` device tree property for domains
Hi Michal,
>>>> +
>>>> +static inline bool v8r_el1_msa_domain_sanitise_config(
>>>> + const struct xen_domctl_createdomain *config)
>>> Why can't this function be common? I can see 3 definitions (Arm64 MPU, Arm32
>>> MPU, MMU) but they do not have anything that would prevent from generalizing
>>> them in a single function.
>>
>> I can do a common one I think, just to be aligned, should the common one
>> behaves as the current implementation?
>>
>> Arm64/32 MMU: Only v8r_el1_msa == XEN_DOMCTL_CONFIG_ARM_V8R_EL1_MSA_NONE
>> allowed
>> Arm64: Only v8r_el1_msa ==
>> XEN_DOMCTL_CONFIG_ARM_V8R_EL1_MSA_{NONE,PMSA,VMSA} allowed
>> Arm32: Only v8r_el1_msa == XEN_DOMCTL_CONFIG_ARM_V8R_EL1_MSA_{NONE,PMSA}
>> allowed
> What's the reason for allowing NONE for MPU here? None denotes property not
> specified but at this point it should be set to a default.
We treat NONE as PMSA on Armv8-R, so either NONE and PMSA are valid and lead to
PMSA at EL1
Cheers,
Luca
|
