[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 3/3] xen: introduce CONFIG_HAS_DOMAIN_TYPE
- To: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: "Orzel, Michal" <michal.orzel@xxxxxxx>
- Date: Tue, 21 Apr 2026 13:55:18 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=gmail.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tps6sBPh3bcNJWiwP/HKZ78/QClVFItbNQVw+grFdbo=; b=sYAehtareVuPV5dxgrg6riazFel3pORhcsn0nAw9Uile3D0zdcu6p5WADP7abF8aunP4uwnTyZAbkEJYV2TtAoBTXW5+fGh7RJtMamL95XrHBJrtInOTho9U9yELxQ5O1BbobfyJ/+H3rGQ8nNht/kt/775K4Mn8KADBi5DDkQq+TthXDqC/BpW1jduAPqCd/1BrvckpenzAvHcm1TXK45dWyurWSsM9SsWPdxpX9PxaA5/aa+QwXaufvpdq4fLbHEC2Yl7kWvREBuyy6hthcf1S7BLiX6ZyWbx06+W3eTUJUBJOjrwPUOvZifLwx9r+bmWOtBWpI2MstvM7tR5Wcw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=b8HPzld+JtV6cPym+11U/veem2ccdaMt7ffVtekV7xFTxQXzFzwsYABjj3hmKgNwtyyWGDO6FXk+Gm6OJsm2FbACQEBQOu4F9Mdezuk7m4SBjsBsmdvcbRYRDfvNNbJZp3w8TfQg98hIUUSvT5oy/mhHiPsZIqoUFo0hX2twS9u04IF7RWwFuKohbl7V39zWfrG14zcBLXL5YObk8DbSIP4ACNTIUH8S95W0qf74sdyD9zEQbwCH16eWJVaITJQIb+KC33AXChSIR9Xo3AhedCz4QGr3CQGM64D+aysyNejFMV85LXquPGn9eHGZqDNIK7UCx0b+HmZRsUqqQo//pg==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=amd.com header.i="@amd.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Tue, 21 Apr 2026 11:55:31 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 21/04/2026 13:06, Oleksii Kurochko wrote:
>
>
> On 4/20/26 10:03 AM, Orzel, Michal wrote:
>>
>>
>> On 16/04/2026 16:21, Oleksii Kurochko wrote:
>>> As domain type is part of common code now there is no any reason
>>> to have architecture-specific set_domain_type() functions so
>>> it is dropped.
>>>
>>> The CONFIG_ARM_64 guard in xen/arch/arm/domain_build.c is intentionally
>>> left unchanged: it is ARM-specific code, and ARM_64 selects
>>> HAS_DOMAIN_TYPE, so the semantics are identical.
>>>
>>> x86 with CONFIG_64BIT=y shouldn't use is_{32,64}bit_domain() as
>>> x86 doesn't have support of CONFIG_HAS_DOMAIN_TYPE. For x86_32
>>> it is fine to follow generic is_{32,64}_bit_domain() implementations.
>> I thought x86_32 Xen no longer builds. This means the fallback is only for
>> arm32.
>
> Will you be okay with
> Since x86_32 Xen no longer builds, the fallback is currently only
> relevant for arm32.
Yes. I would.
~Michal
|
