[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] xvmalloc: adjust XVFREE() ordering


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Date: Thu, 16 Apr 2026 16:39:49 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CCexuXcnCPR6FD9OUkYshKxyTvIRaUTsQO9BnYK2Gxw=; b=OvyMFWxyWpLrOp9POE8hNN7jyn4hYF8vc6UWgB1BIuw+wQAcdxUgBPOSYJ9gitSHj3AUfW1S9rtBBEGT3lNXS/uP0gHpmomoGhNH68InLmexOnsGZUqt9eDEe7YbTucgL2m5qquyz96PNIoAA2EDgDYEG23Z2QSSeJ0IY/kmWqHxV55viNi9aj0j6Jt4Rjj14QACsaLHhDsWmXwlZCxsI7Y48b2yWJ61xJnJ5ZiXvHhMLZy2YtCBX4IYZ/FbQXmKVj42FK4620G5VZZzJcnYsWKxAitfsAN8s3SnDAH2KRvx4gEVJrlDTDaC8HM44bKnd49WjL7KAFOJ6IqEE+BGHg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Dw71vAar2EKnna1hiHQ5DBl9dwllhTpfABD2S6OxxtKJEv4qIyHWvyxqDqPQi9wX1CSq9VjlSBuGvAnW0xGHPVOiq6moTfE63Uq0I0gV8EsyOKWf+x9laff8H6edWWwpHuvQ9YXMuKfk+BnSUqUi4tR1bSOraPDyOAiuxoOEClvt/NCdlQli7E2q5O0C7ZPF4FVHNELkLn7jZ1o4IBEGU7m3Bsmo9KU2Y9Tue2DoKvMHJkFTKepUyjB5ffGquJl4Dld+WO+Ngh9czzGRNfxXocjcFXTms5o2ZlNIJ0EaH/Dzo9s3fLa5aTjI4lF95MFS+1ixDdR5Ya7w5PBn3HzGPw==
  • Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>
  • Delivery-date: Thu, 16 Apr 2026 14:40:07 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Thu, Apr 16, 2026 at 04:32:54PM +0200, Jan Beulich wrote:
> What c4f427ec879e ("xen: Swap order of actions in the FREE*() macros") did
> should have been done right away when XVFREE() was introduced.
> 
> Amends: 9102fcd9579f ("mm: introduce xvmalloc() et al and use for grant table 
> allocations")
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Acked-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

No intention to stir controversy, but I feel like this should better
use the Fixes tag, as it's not an omission or similar, but code fix.

Thanks, Roger.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.