[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/2] xen/arm: optee: Add MISRA-compliant switch default labels


  • To: Bertrand Marquis <bertrand.marquis@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: "Orzel, Michal" <michal.orzel@xxxxxxx>
  • Date: Fri, 20 Mar 2026 10:16:57 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=arm.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7eeZGSvzIySCPkF0XqPe02MVVawYn69quaGtofXl5Bc=; b=Ervt8eDBXlAe5bXtTHZOMxy2lGImupKgxQppalGsdHvbRQ5+2K6M5JzK1Q4lNwTprZ1t2okpZN0ZWJNfdt0/HkHIE7zV9bq2sLZAvk5h/laA0LtqRIaEWiZJdgIgtcs8GwCeSbNewjC9zA5rqwQ5v5E74DTnMtCReNY4vOEPlnM8xVurXolAaNIcbJG9aPz5/4wGy0ZvpA1rsd9GtX6yteW+kf8kQ5+IkWc9WWQXccObKvgbkUhDV5kP3ThSa37od8g7Hf65DG1F4r1DBun4LHW8WCZ9/5VxcriOMYonnLeX1+fMXgWrbKFNq7xuvg8r4Mm7H5otKQk3paflk1KXyQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=TBNdxNc5WlLPBSbeOUYcv9U47Uam9TNRPxAHYwim0V+iykAV5Drz0vbrg88LNE1Jt9BfS+rTwiB7YapYbE91x01L870hNHfE9+Kw3ChwDTzKLFQ/l6VAzX/pg083vS/kRjTFG9lh2XJqnsnQm4Oq7hQOWOWh2FajA3o4k+FRTolqFd/auMPYI8M4h4931oBFOeA/ZFyEFzdqtqMuN/kEPWJit+zRzvn+E3XGJx0yXRDwxTz05BJ5vFK3xhNIm3Aa06OjMxsM39IAcagirglbXhoYQCQ3b5GFBtH6wrWgRk8dhtLEiQSy8I1nBKy6rMyqnsYMJFlF9dDQrLI6YKdnRA==
  • Cc: Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>, Jens Wiklander <jens.wiklander@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>
  • Delivery-date: Fri, 20 Mar 2026 09:17:12 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>


On 20/03/2026 10:07, Bertrand Marquis wrote:
> optee.c has several switch statements over integer-valued OP-TEE fields
> without a default label, and two default clauses that only contain
> break. This triggers MISRA C Rule 16.4 findings.
> 
> Add explicit default labels to all reported switches and document the
> intentional no-op defaults with rationale comments. The new default
> paths preserve the existing behavior:
> - unsupported parameter attribute types are ignored;
> - non-handled RPC commands require no post-processing in Xen;
> - unknown RPC function IDs are resumed unchanged.
> 
> No functional changes.
> 
> Signed-off-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>

~Michal




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.