[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] arm/tee: rename variable to address MISRA C Rule 5.3
- To: Dmytro Prokopchuk1 <dmytro_prokopchuk1@xxxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Fri, 20 Mar 2026 09:09:27 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=epam.com smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8snH/ssz8nnANhJ2IOTzoWuv6JRMcs45u+juXqa06w0=; b=IBD5JicI46Fcro5sbH0V+6yTDL3Oq1uoC0VW0Jhmsx8fuYUfoLQUdXLTDP7gAuArdMZyv88z1yE/QLvWcCBZhtEzoGf+Gc4x0xZWrRQ2t8If8zhwTXF6LHjdk9yfbRn3psVf4KivMYqggzi4RF4pY4/vBc4q6Qnbllr2P3hRgQk/gsSuC9PaXwHU+KdqO6eJHLfFoHayuSuwWX+obyT6EsQsg5SP9KtW7RgIfogguvmtHcE+l+kRhu40a+oHD9KqRHpsj5+HDCER1j3Q4WjfEuF3Qz2iSeYVLtoZ9EJUf5ziInAh7XvcWC+pdoQMEWt1GAEonfunsGsfwEaywZdj6w==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8snH/ssz8nnANhJ2IOTzoWuv6JRMcs45u+juXqa06w0=; b=Va8xLoJHQGy0+IFpc1SSujXnp0Axn8+6NIct9xzkgOjN0fSuS9NjwKV8VMIm/+3BMss64CRL/iqh/WI5iY3uRthbsEd//GV1RI22b0QtV4ex5gxtPi1KvEPXu1alKUQsRgf8dyWnCBisTO41sqRcRgl9Q0jQxw25liPZDOur5SASGRtRwGoleQSAZD3d6yq+tQsp1mR1vQDPkJdmBB6d21WiLWnjTLpAjXwdt++Klja31vNxCLjd1zWe1hmr9MCr5zsi2I+6Nld7A/J/t9+O1nSsIYbUi/D3aMRatJOnSJ9d6eBdBuUpekX61AFJKIw+wKFolQcSpcAyGT+OaTvu1w==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=iXNHUQpwbz9K9e1mL3ZlwzZxVxWj8bP41MzOkgqU9k8Z0t/DB1SAIkNdzUvxCT4p8lKig7L3GwjL7RwRt/3+MK8WPV5vBn6aapC3ts3sIFicwxPUrFJZob4uEW2Q9qxKkfppRBoJApGS/i1E10LcI/bL2U2yDCrrU9HBTeGGytSVbtyWjXJx+yvyLV1DBpADFcsg2LDii5+kPiG7FfZLZZ0dBaqy1J7wudgey/wqku4hvsIFmCzwIgeHHJp+7sECOfzvcTfWmnkicoSqQMLGK+104pbQLd2JfmvQ9PyjoR/WNjK8Xn9XyRJNze7/8xRQFH/y0DMZ6Z02Ev9B2QVXFw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=AkYbeCT9ajo2oJsQes+lAWXsYWZbvDT1XkT6xv4LAowa8VRgcyGXlrNVWmHFgwRmxNweuScYhWX4XFglXZFkO8/5gizn2wbwz2bMtt1cVFw3M21Po5slYd/gwemMC9d1cAUX1YJbOueaPNk3xN3b5U6TbL4svMvzWLdF/f38Cvy/Vu02uxN7h/fPJtKexzpUw5ztRdEymeTOQKzjnqyg5JXuJSzNCooVNe1+Dll6mFomoSPvMWrEcXIdoPkq/QN7qPm8WRgXg/Xd34yeUKVxbBXeuicLdQV9L5xWKKjlEhk0i2W60ofJjCllAsdD3E9HbEB9FnCvdNXXye06/RpIgQ==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Jens Wiklander <jens.wiklander@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>
- Delivery-date: Fri, 20 Mar 2026 09:10:43 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Thread-index: AQHct91SP+heAl5ESUaIOkxQ7VfzerW3Cw6AgAATegCAAAQygA==
- Thread-topic: [PATCH] arm/tee: rename variable to address MISRA C Rule 5.3
> On 20 Mar 2026, at 09:54, Dmytro Prokopchuk1 <dmytro_prokopchuk1@xxxxxxxx>
> wrote:
>
>
>
> On 3/20/26 09:44, Bertrand Marquis wrote:
>> Hi Dmytro,
>>
>>
>>> On 19 Mar 2026, at 21:16, Dmytro Prokopchuk1 <dmytro_prokopchuk1@xxxxxxxx>
>>> wrote:
>>>
>>> The local variable 'ffa_vm_count' shadows the global variable, declared
>>> in 'xen/arch/arm/tee/ffa_private.h', therefore it is renamed
>>> 'ffa_vm2vm_count'.
>>
>> I have a patch in my queue to solve this (I am just removing the ffa_ prefix
>> from the local
>> variables but does the same as yours) and a patch to solve the other misra
>> issue in optee
>> but happy to to use yours if you want instead.
>>
>> I was waiting for the pending ffa serie to push them (should be merge soon)
>>
>> This patch will not rebase cleanly on top of that serie which is changing
>> ffa_partinfo code.
>>
>> Do you want to wait and rebase or abandon and use the one in my serie
>> instead ?
>>
>> I am ok with either solution :-)
>>
>> Cheers
>> Bertrand
>
> Hi Bertrand,
>
> lets use your patch series.
I just sent it with a warning in the cover letter for its base.
Cheers
Bertrand
|
