Re: [PATCH 07/11] tools/xenstored: implement the GET/SET_QUOTA commands

[Jürgen Groß <jgross@xxxxxxxx>]

On 19.03.26 17:47, Anthony PERARD wrote:
> On Mon, Mar 16, 2026 at 04:27:43PM +0100, Juergen Gross wrote:
> > On 16.03.26 16:08, Anthony PERARD wrote:
> > > On Thu, Mar 05, 2026 at 02:52:04PM +0100, Juergen Gross wrote:
> > > > +               if (n_pars == 1) {
> > > > +                       quota = quotas;
> > > > +                       name = vec[0];
> > > > +               } else {
> > > > +                       domid = atoi(vec[0]);
> > > Shall we check that vec[0] actually contain a plausible domid? (An
> > > integer between 0..65535). Right now, this accept everything, and would
> > > return 0 if there's not a single digit.
> > I have followed the pattern used in other places where a domid is expected.
> >
> > In the end nothing will really break.
> On the daemon, no, not really.
>
> > Any integer not being a domid will result in ENOENT, while the case of not
> > a digit is a bug in privileged software (domids can be specified by dom0
> > only).
> It would be a bug, indeed, but xenstored can help telling exactly where
> there's a bug, instead of ignoring it and carry-on. Well, just return
> EINVAL when something other than a number is found. You do that for
> quota, why not for domid as well?
>
> That can also help when the daemon is replace by a different
> implementation that actually do the checks. (well it would help finding
> bug in the client earlier)
I have added another patch introducing a domid parser and using it where
needed.


Juergen

Attachment: OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature