[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 2/8] x86/vmx: Remove lazy FPU support
- To: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Thu, 19 Mar 2026 17:06:30 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zSDBoA2OFcMkOmtkj9E6iHSCXzq7l7lmsvXKRHl9Sk8=; b=R+HMamw//Rqm0YuqzG1k2zCp2OT2CcBSZzqUdxCE/BVgyV7y8674ESg8nQ+RcjRa5srtTv+RWxnj+xNr377UFXMXNxVMuSmLE+tEBjlyjmhu6pTXioNFwI8JJWJLVL98vOdOLjds9Ti9/jD7TDaTT1P0pXg0kgU0VFryRahECOQNfrcu4nBk7HgGALyo1P1SWoG3+ECXoPuEjnAwXII2IvoJKMwRrIyZ/c5Ia3gp4R9HW0bEGQC8hpHfOoK+I0Zp4fa2H/gX7GnDVlxDwrOBvnPGTLqhpZbky//ZzstfyZhDvMLn6++XFoC/Pb8wcq1blyD65FI/w2VayipyGsZhEA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=quHlHfu3ZuXVHOS+3oLu+b5d+GpEvLFTQYomT6JJqLVr3jsTpzHgcxwrN73XmXznCVB4ywJg8cKbulJabqJlgYJy/7UPKvsuK5Z72xM8M31AMWWzG609pZa9paVZp3ahRd5AELj7FSSuh2XICjrX84MMDIAv24uElV1WgyUGfUlGx+DViXGlq6m8ZJ4edjtPUD+2Q3Vc1DvkTNrWsuJq3DQKAXOt6mqwfFVnOXV7nr/1IF0sa6AkNeocUOU4z+rHNC9ZX/g9+qVCD6WZ0X2E2+pMoBIpQNgtJGOMov9jg3yD+S5NDC/cfntyMxzcZB4D4L4zf8sX687oR+rno8gQ4Q==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Thu, 19 Mar 2026 17:06:58 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 19/03/2026 1:29 pm, Ross Lagerwall wrote:
> diff --git a/xen/arch/x86/hvm/vmx/vvmx.c b/xen/arch/x86/hvm/vmx/vvmx.c
> index 38952f06961e..e4cdfe55c18e 100644
> --- a/xen/arch/x86/hvm/vmx/vvmx.c
> +++ b/xen/arch/x86/hvm/vmx/vvmx.c
> @@ -2458,19 +2452,14 @@ int nvmx_n2_vmexit_handler(struct cpu_user_regs *regs,
> __vmread(VM_EXIT_INTR_INFO, &intr_info);
> vector = intr_info & INTR_INFO_VECTOR_MASK;
> /*
> - * decided by L0 and L1 exception bitmap, if the vetor is set by
> - * both, L0 has priority on #PF and #NM, L1 has priority on others
> + * decided by L0 and L1 exception bitmap, if the vector is set by
> + * both, L0 has priority on #PF, L1 has priority on others
> */
Again not for this patch, but this comment is wrong(ish).
L0 #PF only needs to take priority when L1 is a shadow mode guest. A
while back we decided to disallow nested-virt in such a configuration,
so we can delete this special case.
~Andrew
|
