Re: [RFC PATCH] xen: handle domain_shutdown() return values

[Jan Beulich <jbeulich@xxxxxxxx>]

On 19.03.2026 13:42, Mykola Kvach wrote:
> From: Mykola Kvach <mykola_kvach@xxxxxxxx>
> 
> Propagate domain_shutdown() return codes through the shutdown paths
> which can still report errors to their callers, and log explicit
> failures in fire-and-forget paths instead of silently discarding the
> result.
> 
> This makes the shutdown contract explicit for callers which can report
> errors, while preserving observable diagnostics for the remaining
> fire-and-forget paths.
> 
> It also fixes MISRA Dir 4.7 and Rule 17.7 violations by ensuring that
> the returned status is tested or otherwise used.
> 
> Suggested-by: Jan Beulich <jbeulich@xxxxxxxx>

I don't agree with this. For what you want to do (as per the link below)
this is a prereq, but as an independent change I'm not convinced this is
needed. Once it is grouped with that other change, it's kind of natural,
and hence any Suggested-by: would feel odd.

I'm further unconvinced logging is the right course of action in all of
the cases. Some may want to be assertions instead?

Jan

> Signed-off-by: Mykola Kvach <mykola_kvach@xxxxxxxx>
> ---
> Link to discussion: 
> https://patchew.org/Xen/cover.1748848482.git.mykola._5Fkvach@xxxxxxxx/7bd75ecfff5b0a75ea5abd7cc4934582d7e1250c.1748848482.git.mykola._5Fkvach@xxxxxxxx/#90048f71-8313-4110-924c-f956a2bec5a0@xxxxxxxx